[feature](cloud) Implement hdfs accessor #33059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -24,6 +24,7 @@ | |||
| #include <unordered_map> | |||
| #include <unordered_set> | |||
|
|
|||
| #include "recycler/s3_accessor.h" | |||
There was a problem hiding this comment.
warning: 'recycler/s3_accessor.h' file not found [clang-diagnostic-error]
#include "recycler/s3_accessor.h"
^| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include "recycler/hdfs_accessor.h" |
There was a problem hiding this comment.
warning: 'recycler/hdfs_accessor.h' file not found [clang-diagnostic-error]
#include "recycler/hdfs_accessor.h"
^|
|
||
| class HDFSBuilder { | ||
| public: | ||
| ~HDFSBuilder() { |
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~HDFSBuilder() {
^| HDFSBuilder() = default; | ||
|
|
||
| // returns 0 for success otherwise error | ||
| int init(const HdfsBuildConf& conf) { |
There was a problem hiding this comment.
warning: method 'init' can be made static [readability-convert-member-functions-to-static]
Suggested change
| int init(const HdfsBuildConf& conf) { | |
| static int init(const HdfsBuildConf& conf) { |
| } | ||
|
|
||
| // returns 0 for success otherwise error | ||
| int init_hdfs_builder() { |
There was a problem hiding this comment.
warning: method 'init_hdfs_builder' can be made static [readability-convert-member-functions-to-static]
Suggested change
| int init_hdfs_builder() { | |
| static int init_hdfs_builder() { |
| } | ||
|
|
||
| // returns 0 for success otherwise error | ||
| int check_krb_params(std::string_view hdfs_kerberos_principal, |
There was a problem hiding this comment.
warning: method 'check_krb_params' can be made static [readability-convert-member-functions-to-static]
Suggested change
| int check_krb_params(std::string_view hdfs_kerberos_principal, | |
| static int check_krb_params(std::string_view hdfs_kerberos_principal, |
| #ifdef USE_HADOOP_HDFS | ||
| #include <hadoop_hdfs/hdfs.h> // IWYU pragma: export | ||
| #else | ||
| #include <hdfs/hdfs.h> // IWYU pragma: export |
There was a problem hiding this comment.
warning: 'hdfs/hdfs.h' file not found [clang-diagnostic-error]
#include <hdfs/hdfs.h> // IWYU pragma: export
^| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include "recycler/obj_store_accessor.h" |
There was a problem hiding this comment.
warning: 'recycler/obj_store_accessor.h' file not found [clang-diagnostic-error]
#include "recycler/obj_store_accessor.h"
^
platoneko
force-pushed
the
hdfs-accessor
branch
2 times, most recently
from
5088dc9
to
2e53a91
Compare
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include "recycler/hdfs_accessor.h" |
There was a problem hiding this comment.
warning: 'recycler/hdfs_accessor.h' file not found [clang-diagnostic-error]
#include "recycler/hdfs_accessor.h"
^
|
| namespace doris::cloud { | ||
|
|
||
| #define HdfsAccessorTest DISABLED_HdfsAccessorTest | ||
| TEST(HdfsAccessorTest, normal) { |
There was a problem hiding this comment.
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
TEST(HdfsAccessorTest, normal) {
^Additional context
cloud/test/hdfs_accessor_test.cpp:47: 92 lines including whitespace and comments (threshold 80)
TEST(HdfsAccessorTest, normal) {
^
|
|
run buildall |
|
run compile |
dataroaring
force-pushed
the
hdfs-accessor
branch
from
cbfd416
to
c72c61a
Compare
|
run buildall |
gavinchou
approved these changes
Apr 2, 2024
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 38983 ms |
TPC-DS: Total hot run time: 181489 ms |
ClickBench: Total hot run time: 31.79 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implement hdfs accessor
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...