[enhancement](mysql compatible) add user and procs_priv tables to mysql db in all catalogs #33058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zy-kkk
force-pushed
the
mysqldb_table
branch
2 times, most recently
from
d4953f7
to
73195aa
Compare
|
run buildall |
TPC-H: Total hot run time: 38700 ms |
TPC-DS: Total hot run time: 183902 ms |
ClickBench: Total hot run time: 29.52 s |
|
TeamCity be ut coverage result: |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
wangbo
reviewed
Mar 30, 2024
| SCH_WORKLOAD_GROUPS("WORKLOAD_GROUPS", "WORKLOAD_GROUPS", TSchemaTableType.SCH_WORKLOAD_GROUPS); | ||
| SCH_WORKLOAD_GROUPS("WORKLOAD_GROUPS", "WORKLOAD_GROUPS", TSchemaTableType.SCH_WORKLOAD_GROUPS), | ||
| SCHE_USER("user", "user", TSchemaTableType.SCH_USER), | ||
| SCH_PROCS_PRIV("procs_priv", "procs_priv", TSchemaTableType.SCH_PROCS_PRIV); |
There was a problem hiding this comment.
Where is procs_priv's schema scanner?
There was a problem hiding this comment.
procs_priv does not need a scanner for the time being, just use SchemaDummyScanner to read empty data.
wangbo
reviewed
Mar 30, 2024
| @@ -1937,4 +1938,97 @@ public String getDefaultCloudCluster(String user) { | |||
| return cluster; | |||
| } | |||
| // ====== END CLOUD ====== | |||
|
|
|||
| // for mysql.user table | |||
| public List<List<String>> getAllUserInfo() { | |||
There was a problem hiding this comment.
UserInfo is hard code data, why not fill it in be and avoid rpc?
There was a problem hiding this comment.
Because the data in userinfo requires permissions and password policies, FE can better directly determine the data that needs to be sent.
wangbo
reviewed
Mar 30, 2024
| @@ -409,6 +409,8 @@ protected List<String> filterDatabaseNames(List<String> remoteDbNames) { | |||
| protected Set<String> getFilterInternalDatabases() { | |||
| return ImmutableSet.<String>builder() | |||
| .add("information_schema") | |||
| .add("performance_schema") | |||
There was a problem hiding this comment.
Why filter performance_schema?
There was a problem hiding this comment.
We do not need to obtain MySQL's performance_schema in Doris, which will increase the burden of obtaining metadata, so filtering
|
Please add regression test to select data from user/procs_priv, and show their schema. |
wangbo
reviewed
Mar 30, 2024
|
|
||
| import java.util.List; | ||
|
|
||
| public class ExternalMysqlDatabase extends ExternalDatabase { |
There was a problem hiding this comment.
1 How to use exeternal mysql database?
2 Can regression test be added to it?
There was a problem hiding this comment.
When creating ExternalCatalog, a database named mysql will be automatically created. This is to be compatible with some BI tools. It is used in ExternalCatalog.java. Unit tests and regression tests have been added to it.
This part of the test will be added later. I will obtain the statements sent when connecting to Doris from various BI or Database IDE tools and add them to the regression test. |
…ql db in all catalogs
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| {"password_policy.failed_login_counter", TYPE_VARCHAR, sizeof(StringRef), false}, | ||
| {"password_policy.lock_time", TYPE_VARCHAR, sizeof(StringRef), false}}; | ||
|
|
||
| SchemaUserScanner::SchemaUserScanner() |
There was a problem hiding this comment.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
be/src/exec/schema_scanner/schema_user_scanner.cpp:66:
- : SchemaScanner(_s_user_columns, TSchemaTableType::SCH_USER) {}
+ : SchemaScanner(_s_user_columns, TSchemaTableType::SCH_USER) = default;
TPC-H: Total hot run time: 38800 ms |
TPC-DS: Total hot run time: 182168 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.68 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
wuwenchi
approved these changes
Apr 2, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 13, 2024
…ql db in all catalogs (#33058) Issue Number: close #xxx This PR aims to enhance the compatibility of BI tools (such as Dbeaver, DataGrip) when using the mysql connector to connect to Doris, because some BI tools query some tables in the mysql database. In our tests, the user and procs_priv tables were mainly queried. This PR adds these two tables and adds actual data to the user table. However, please note that most of the fields in the user table are in Doris' own format rather than mysql format, so it can only ensure that the BI tool is querying No error is reported when accessing these tables, which does not guarantee that the data is completely displayed, and the tables under Doris's mysql database do not support data modification. Thanks to @liujiwen-up for assisting in testing
yiguolei
pushed a commit
that referenced
this pull request
Apr 17, 2024
…ql db in all catalogs (#33058) Issue Number: close #xxx This PR aims to enhance the compatibility of BI tools (such as Dbeaver, DataGrip) when using the mysql connector to connect to Doris, because some BI tools query some tables in the mysql database. In our tests, the user and procs_priv tables were mainly queried. This PR adds these two tables and adds actual data to the user table. However, please note that most of the fields in the user table are in Doris' own format rather than mysql format, so it can only ensure that the BI tool is querying No error is reported when accessing these tables, which does not guarantee that the data is completely displayed, and the tables under Doris's mysql database do not support data modification. Thanks to @liujiwen-up for assisting in testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
This PR aims to enhance the compatibility of BI tools (such as Dbeaver, DataGrip) when using the mysql connector to connect to Doris, because some BI tools query some tables in the mysql database. In our tests, the user and procs_priv tables were mainly queried. This PR adds these two tables and adds actual data to the user table. However, please note that most of the fields in the user table are in Doris' own format rather than mysql format, so it can only ensure that the BI tool is querying No error is reported when accessing these tables, which does not guarantee that the data is completely displayed, and the tables under Doris's mysql database do not support data modification.
Thanks to @liujiwen-up for assisting in testing
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...