[fix](load) skip cancel rpc if stub is not initialized #33006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 49553 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 200934 ms |
ClickBench: Total hot run time: 30.78 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
cambyzju
reviewed
Mar 29, 2024
| @@ -852,6 +852,10 @@ void VNodeChannel::cancel(const std::string& cancel_msg) { | |||
| // But do we need brpc::StartCancel(call_id)? | |||
| _cancel_with_msg(cancel_msg); | |||
|
|
|||
| if (_stub == nullptr) { | |||
There was a problem hiding this comment.
_stub is created in VNodeChannel::init, if _stub is null, it will set _is_closed to true.
We should not reach here normally.
If we do not find the root cause, please add some comments and logs here.
There was a problem hiding this comment.
I agree with @cambyzju. We should not reach here.
There was a problem hiding this comment.
cancel() could be called when _inited = false, see #34897 (fixed in that PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix coredump in VNodeChannel::cancel
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...