Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](nereids)column name should be case insensitive when selecting mv #33002

Merged
merged 2 commits into from
Mar 29, 2024
Merged

[fix](nereids)column name should be case insensitive when selecting mv #33002

merged 2 commits into from
Mar 29, 2024

Conversation

starocean999
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37500 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 26cc15293c2932ead17e00ba64425afc05cb73d3, data reload: false

------ Round 1 ----------------------------------
q1	17634	4217	4100	4100
q2	2122	161	155	155
q3	10577	1171	1209	1171
q4	10228	785	869	785
q5	7451	2914	2903	2903
q6	202	124	126	124
q7	1041	579	581	579
q8	9346	2001	1999	1999
q9	7173	6326	6268	6268
q10	8460	3436	3560	3436
q11	437	225	224	224
q12	391	206	198	198
q13	17795	2840	2918	2840
q14	244	206	211	206
q15	513	454	457	454
q16	494	374	373	373
q17	945	526	597	526
q18	7127	6368	6442	6368
q19	3733	1435	1450	1435
q20	552	253	250	250
q21	3596	2882	2820	2820
q22	339	286	305	286
Total cold run time: 110400 ms
Total hot run time: 37500 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4178	4133	4095	4095
q2	323	232	229	229
q3	2939	2849	2858	2849
q4	1835	1561	1548	1548
q5	5203	5221	5248	5221
q6	202	117	122	117
q7	2173	1806	1799	1799
q8	3145	3289	3288	3288
q9	8443	8368	8431	8368
q10	3790	3839	3983	3839
q11	545	460	473	460
q12	768	592	573	573
q13	16997	3010	3048	3010
q14	291	272	263	263
q15	510	489	491	489
q16	509	449	457	449
q17	1772	1565	1502	1502
q18	8180	7828	7436	7436
q19	1709	1590	1554	1554
q20	1988	1885	1831	1831
q21	5013	4882	4758	4758
q22	527	460	464	460
Total cold run time: 71040 ms
Total hot run time: 54138 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183154 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 26cc15293c2932ead17e00ba64425afc05cb73d3, data reload: false

query1	933	351	348	348
query2	6334	2111	1987	1987
query3	6699	218	215	215
query4	31604	21480	21358	21358
query5	4278	410	395	395
query6	261	182	196	182
query7	4640	309	295	295
query8	229	171	174	171
query9	9307	2305	2318	2305
query10	413	273	269	269
query11	15380	14275	14228	14228
query12	132	92	85	85
query13	1621	444	433	433
query14	10180	8148	7757	7757
query15	318	188	194	188
query16	8251	268	262	262
query17	2057	585	558	558
query18	2116	290	286	286
query19	349	165	158	158
query20	95	91	87	87
query21	201	128	130	128
query22	4983	4856	4810	4810
query23	33788	32799	32952	32799
query24	10898	2916	2964	2916
query25	586	431	404	404
query26	784	168	155	155
query27	2470	376	376	376
query28	6569	1942	2055	1942
query29	898	671	623	623
query30	330	157	158	157
query31	980	760	764	760
query32	100	60	58	58
query33	793	261	272	261
query34	1252	516	528	516
query35	904	734	705	705
query36	1042	930	896	896
query37	102	70	66	66
query38	3821	3659	3611	3611
query39	1651	1631	1617	1617
query40	187	113	115	113
query41	51	48	49	48
query42	106	102	106	102
query43	494	459	457	457
query44	1257	767	783	767
query45	268	275	244	244
query46	1157	763	775	763
query47	2043	1908	1946	1908
query48	463	371	377	371
query49	841	364	345	345
query50	781	390	403	390
query51	6872	6802	6833	6802
query52	109	94	99	94
query53	355	299	287	287
query54	313	261	239	239
query55	87	86	80	80
query56	245	241	245	241
query57	1293	1180	1202	1180
query58	230	222	213	213
query59	2986	2549	2444	2444
query60	263	234	242	234
query61	94	91	90	90
query62	610	426	431	426
query63	307	280	283	280
query64	5298	4068	4077	4068
query65	3086	3068	3036	3036
query66	740	357	350	350
query67	15775	15139	14892	14892
query68	9267	554	554	554
query69	672	390	382	382
query70	1379	1152	1131	1131
query71	498	266	269	266
query72	6937	2521	2360	2360
query73	1623	324	320	320
query74	6798	6372	6434	6372
query75	3770	2240	2189	2189
query76	5410	875	902	875
query77	621	262	260	260
query78	10928	10170	10120	10120
query79	10432	542	543	542
query80	2003	381	401	381
query81	525	222	224	222
query82	235	88	88	88
query83	205	146	145	145
query84	281	79	80	79
query85	931	326	306	306
query86	344	291	303	291
query87	3845	3516	3605	3516
query88	5533	2423	2403	2403
query89	478	361	371	361
query90	2050	179	177	177
query91	173	135	136	135
query92	57	47	49	47
query93	6204	512	505	505
query94	1258	186	180	180
query95	420	322	320	320
query96	633	278	274	274
query97	2664	2467	2481	2467
query98	230	215	231	215
query99	1075	840	859	840
Total cold run time: 311139 ms
Total hot run time: 183154 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 26cc15293c2932ead17e00ba64425afc05cb73d3 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       13.8 seconds inserted 10000000 Rows, about 724K ops/s

@starocean999 starocean999 marked this pull request as ready for review March 29, 2024 02:10
BiteTheDDDDt
BiteTheDDDDt reviewed Mar 29, 2024
View reviewed changes
regression-test/suites/nereids_p0/test_mv_select.groovy Outdated
`SecondCid` int(11) REPLACE NULL,
`ThirdCid` int(11) REPLACE NULL,
`FourthCid` int(11) REPLACE NULL,
`Price` int(11) REPLACE NULL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s best to simplify the case and do some desensitization

morrySnow
morrySnow previously approved these changes Mar 29, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 29, 2024
@starocean999 starocean999 mentioned this pull request Mar 29, 2024
Merged
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 37760 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d4992e1315811c45fe52196164a7932759c6b0a6, data reload: false

------ Round 1 ----------------------------------
q1	17620	4262	4167	4167
q2	2107	156	152	152
q3	10673	1131	1217	1131
q4	10235	776	829	776
q5	7500	2934	2923	2923
q6	208	126	125	125
q7	1037	588	573	573
q8	9330	2032	2023	2023
q9	6889	6318	6348	6318
q10	8479	3460	3556	3460
q11	443	221	222	221
q12	374	198	198	198
q13	17811	2898	2862	2862
q14	226	208	204	204
q15	517	466	457	457
q16	495	366	369	366
q17	945	641	584	584
q18	7143	6399	6590	6399
q19	4607	1465	1503	1465
q20	556	248	256	248
q21	3582	2945	2818	2818
q22	344	296	290	290
Total cold run time: 111121 ms
Total hot run time: 37760 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4172	4089	4106	4089
q2	327	228	225	225
q3	2954	2847	2826	2826
q4	1830	1615	1590	1590
q5	5207	5235	5228	5228
q6	195	117	118	117
q7	2207	1787	1801	1787
q8	3171	3308	3288	3288
q9	8392	8424	8418	8418
q10	3755	3824	3818	3818
q11	550	460	462	460
q12	761	610	594	594
q13	17120	3060	3041	3041
q14	289	261	264	261
q15	535	474	468	468
q16	505	450	448	448
q17	1757	1539	1519	1519
q18	7788	7828	7641	7641
q19	1732	1538	1629	1538
q20	1959	1750	1739	1739
q21	5016	4794	4827	4794
q22	539	463	452	452
Total cold run time: 70761 ms
Total hot run time: 54341 ms

@starocean999 starocean999 merged commit 367836a into apache:master Mar 29, 2024
27 of 31 checks passed
yiguolei pushed a commit that referenced this pull request Apr 1, 2024
@starocean999 @Doris-Extras
[fix](nereids)column name should be case insensitive when selecting mv (
54e86f6 
#33002)
yiguolei pushed a commit that referenced this pull request Apr 10, 2024
@starocean999 @Doris-Extras
[fix](nereids)column name should be case insensitive when selecting mv (
2ee6f28 
#33002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@englefly englefly englefly approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@morrySnow morrySnow morrySnow left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.8-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@starocean999 @doris-robot @englefly @BiteTheDDDDt @morrySnow @xiaokang