Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](iceberg) no need to check the name format of iceberg's database #32977

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[opt](iceberg) no need to check the name format of iceberg's database #32977

merged 1 commit into from
Mar 28, 2024

Conversation

morningman
Copy link
Contributor

Proposed changes

No need to check the name format of iceberg's database.
We should accept all databases.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morningman
Copy link
Contributor Author

run buildall

@morningman morningman mentioned this pull request Mar 28, 2024
Merged
@doris-robot
Copy link

TPC-H: Total hot run time: 37909 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e27a3c071d94d55bef16f7be75a68315ade36095, data reload: false

------ Round 1 ----------------------------------
q1	17938	4345	4182	4182
q2	2601	168	166	166
q3	10910	1164	1233	1164
q4	10547	844	811	811
q5	7558	3007	2946	2946
q6	206	130	128	128
q7	961	518	533	518
q8	9444	2024	2007	2007
q9	6989	6334	6307	6307
q10	8414	3455	3558	3455
q11	441	227	216	216
q12	366	200	201	200
q13	17794	2854	2860	2854
q14	229	214	209	209
q15	502	453	453	453
q16	488	380	386	380
q17	955	525	624	525
q18	7278	6550	6545	6545
q19	1555	1481	1410	1410
q20	549	269	258	258
q21	3676	3025	2881	2881
q22	349	294	302	294
Total cold run time: 109750 ms
Total hot run time: 37909 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4055	4069	4070	4069
q2	324	235	224	224
q3	3138	2836	2842	2836
q4	1807	1516	1518	1516
q5	5203	5233	5234	5233
q6	198	116	118	116
q7	1773	1353	1361	1353
q8	3188	3282	3271	3271
q9	8437	8439	8424	8424
q10	3778	3790	3768	3768
q11	543	448	440	440
q12	718	552	531	531
q13	16904	2845	2813	2813
q14	291	263	264	263
q15	498	455	462	455
q16	480	429	430	429
q17	1716	1496	1439	1439
q18	7409	7393	7129	7129
q19	1591	1494	1540	1494
q20	1906	1725	1715	1715
q21	4845	4471	4636	4471
q22	529	468	452	452
Total cold run time: 69331 ms
Total hot run time: 52441 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181847 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e27a3c071d94d55bef16f7be75a68315ade36095, data reload: false

query1	923	376	358	358
query2	6541	2062	1912	1912
query3	6715	209	209	209
query4	31961	21353	21384	21353
query5	4276	413	395	395
query6	268	183	185	183
query7	4627	296	295	295
query8	229	168	170	168
query9	9195	2321	2282	2282
query10	557	253	268	253
query11	14964	14233	14229	14229
query12	136	97	88	88
query13	1621	431	413	413
query14	10480	7826	7545	7545
query15	248	188	183	183
query16	8196	262	253	253
query17	1975	574	536	536
query18	2098	289	293	289
query19	312	154	152	152
query20	97	88	93	88
query21	203	130	126	126
query22	5021	4744	4778	4744
query23	33388	32712	32952	32712
query24	11996	2872	2840	2840
query25	642	369	366	366
query26	1802	153	152	152
query27	3049	308	314	308
query28	7927	1888	1890	1888
query29	1045	643	614	614
query30	312	149	149	149
query31	985	726	729	726
query32	95	60	56	56
query33	775	265	262	262
query34	1037	494	490	490
query35	905	706	708	706
query36	1026	895	898	895
query37	271	64	69	64
query38	3498	3436	3426	3426
query39	1603	1528	1531	1528
query40	294	114	113	113
query41	52	48	48	48
query42	102	98	97	97
query43	499	466	452	452
query44	1198	753	733	733
query45	275	258	274	258
query46	1114	695	695	695
query47	1924	1920	1796	1796
query48	448	359	363	359
query49	1236	348	339	339
query50	776	378	376	376
query51	6790	6634	6680	6634
query52	104	93	92	92
query53	354	276	278	276
query54	330	249	239	239
query55	85	81	78	78
query56	258	240	244	240
query57	1203	1134	1127	1127
query58	242	210	208	208
query59	2873	2833	2623	2623
query60	280	252	252	252
query61	118	112	114	112
query62	648	438	463	438
query63	304	281	277	277
query64	6449	4147	4240	4147
query65	3136	3040	3035	3035
query66	1451	378	369	369
query67	15431	14958	15205	14958
query68	8631	551	557	551
query69	630	374	399	374
query70	1233	1159	1133	1133
query71	505	271	270	270
query72	6378	2517	2391	2391
query73	799	317	329	317
query74	6918	6556	6414	6414
query75	3776	2247	2278	2247
query76	5355	916	870	870
query77	648	269	268	268
query78	10965	10183	10199	10183
query79	10254	520	526	520
query80	1598	377	365	365
query81	511	219	211	211
query82	741	89	86	86
query83	209	147	142	142
query84	283	93	82	82
query85	1445	321	309	309
query86	422	281	300	281
query87	3749	3607	3483	3483
query88	4780	2289	2292	2289
query89	503	367	367	367
query90	2019	180	177	177
query91	173	152	137	137
query92	58	47	53	47
query93	6871	512	479	479
query94	1202	174	177	174
query95	416	307	301	301
query96	593	277	273	273
query97	2628	2452	2497	2452
query98	232	222	205	205
query99	1265	861	842	842
Total cold run time: 314763 ms
Total hot run time: 181847 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit e27a3c071d94d55bef16f7be75a68315ade36095 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       13.8 seconds inserted 10000000 Rows, about 724K ops/s

kaka11chen
kaka11chen approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 50815b1 into apache:master Mar 28, 2024
27 of 29 checks passed
morningman added a commit that referenced this pull request Mar 29, 2024
@morningman
[opt](iceberg) no need to check the name format of iceberg's database #…
59fb37e 
…32977 (#32979)

bp #32977

Also fix some gson serde issue like:
```
XXX declares multiple JSON fields named runnable.
```
yiguolei pushed a commit that referenced this pull request Apr 1, 2024
@morningman @Doris-Extras
[opt](iceberg) no need to check the name format of iceberg's database (…
3096c94 
…#32977)

No need to check the name format of iceberg's database.
We should accept all databases.
morningman added a commit to morningman/doris that referenced this pull request Apr 7, 2024
@morningman
[opt](iceberg) no need to check the name format of iceberg's database (…
8bb2ef1 
…apache#32977)

No need to check the name format of iceberg's database.
We should accept all databases.
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@morningman
[opt](iceberg) no need to check the name format of iceberg's database a…
f856d06 
…pache#32977 (apache#32979)

bp apache#32977

Also fix some gson serde issue like:
```
XXX declares multiple JSON fields named runnable.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaka11chen kaka11chen kaka11chen approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.8-merged dev/2.1.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morningman @doris-robot @kaka11chen @zy-kkk