[shuffle](fix) Do not use copy assignment for TUniqueId #32969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38121 ms |
yiguolei
reviewed
Mar 28, 2024
be/src/pipeline/task_scheduler.cpp
Outdated
| Status cancel_status = fragment_ctx->get_query_ctx()->exec_status(); | ||
| _close_task(task, PipelineTaskState::CANCELED, cancel_status); | ||
| if (task->is_pending_finish()) { | ||
| // Only meet eos, should set task to PENDING_FINISH state |
TPC-DS: Total hot run time: 181207 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
Gabriel39
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37598 ms |
TPC-DS: Total hot run time: 182250 ms |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
yiguolei
approved these changes
Mar 29, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Mryange
approved these changes
Mar 29, 2024
BiteTheDDDDt
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...