Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exec](column) change some complex column move to noexcept #32954

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[exec](column) change some complex column move to noexcept #32954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/olap/hll.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class HyperLogLog {
}
}

HyperLogLog(HyperLogLog&& other) {
HyperLogLog(HyperLogLog&& other) noexcept {
this->_type = other._type;
switch (other._type) {
case HLL_DATA_EMPTY:
Expand All @@ -131,7 +131,7 @@ class HyperLogLog {
}
}

HyperLogLog& operator=(HyperLogLog&& other) {
HyperLogLog& operator=(HyperLogLog&& other) noexcept {
if (this != &other) {
if (_registers != nullptr) {
delete[] _registers;
Expand Down
4 changes: 2 additions & 2 deletions be/src/util/bitmap_value.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ class BitmapValue {
}
}

BitmapValue(BitmapValue&& other) {
BitmapValue(BitmapValue&& other) noexcept {
_type = other._type;
switch (other._type) {
case EMPTY:
Expand Down Expand Up @@ -1265,7 +1265,7 @@ class BitmapValue {
return buf;
}

BitmapValue& operator=(BitmapValue&& other) {
BitmapValue& operator=(BitmapValue&& other) noexcept {
if (this == &other) {
return *this;
}
Expand Down
5 changes: 5 additions & 0 deletions be/src/util/quantile_state.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ class QuantileState {
QuantileState();
explicit QuantileState(float compression);
explicit QuantileState(const Slice& slice);
QuantileState& operator=(const QuantileState& other) noexcept = default;
QuantileState(const QuantileState& other) noexcept = default;
QuantileState& operator=(QuantileState&& other) noexcept = default;
QuantileState(QuantileState&& other) noexcept = default;

void set_compression(float compression);
bool deserialize(const Slice& slice);
size_t serialize(uint8_t* dst) const;
Expand Down
Loading