Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick "[chore](ColdHeatSeparation) Reduce the frequency of log following read failure #32706" #32711

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Mar 22, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 25, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.81% (8047/21284)
Line Coverage: 29.47% (65706/222976)
Region Coverage: 28.94% (33827/116889)
Branch Coverage: 24.79% (17366/70050)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8c3cdc56d8e795ffefa8c81f757f0801e70b6066_8c3cdc56d8e795ffefa8c81f757f0801e70b6066/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 49659 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8c3cdc56d8e795ffefa8c81f757f0801e70b6066, data reload: false

------ Round 1 ----------------------------------
q1	17823	4464	4332	4332
q2	2025	144	139	139
q3	10319	1903	1905	1903
q4	10378	1242	1310	1242
q5	8297	4008	3962	3962
q6	233	123	120	120
q7	2039	1606	1626	1606
q8	9515	2699	2700	2699
q9	13036	10440	10354	10354
q10	8622	3501	3492	3492
q11	408	241	237	237
q12	465	304	310	304
q13	18357	3959	4011	3959
q14	352	320	325	320
q15	512	458	449	449
q16	703	592	579	579
q17	1130	968	940	940
q18	7180	6795	6765	6765
q19	1669	1540	1482	1482
q20	551	314	303	303
q21	4439	4074	4076	4074
q22	489	404	398	398
Total cold run time: 118542 ms
Total hot run time: 49659 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4312	4355	4298	4298
q2	313	218	221	218
q3	4118	4124	4094	4094
q4	2759	2744	2740	2740
q5	7231	7189	7152	7152
q6	233	118	117	117
q7	3275	2847	2871	2847
q8	4448	4404	4498	4404
q9	17086	16859	16981	16859
q10	4219	4318	4204	4204
q11	759	686	679	679
q12	1036	826	857	826
q13	7052	3740	3747	3740
q14	453	422	431	422
q15	487	437	453	437
q16	755	708	725	708
q17	3805	3838	3888	3838
q18	8804	8728	8688	8688
q19	1714	1660	1646	1646
q20	2379	2123	2088	2088
q21	8496	8462	8477	8462
q22	1073	943	1018	943
Total cold run time: 84807 ms
Total hot run time: 79410 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 204709 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8c3cdc56d8e795ffefa8c81f757f0801e70b6066, data reload: false

query1	928	399	391	391
query2	6513	2314	1960	1960
query3	6915	204	194	194
query4	20265	18134	18133	18133
query5	19732	6533	6514	6514
query6	288	213	230	213
query7	4153	301	298	298
query8	254	250	227	227
query9	3173	2766	2650	2650
query10	408	286	282	282
query11	11582	10880	11301	10880
query12	131	81	79	79
query13	5737	667	649	649
query14	19157	13784	13667	13667
query15	372	237	245	237
query16	9102	279	271	271
query17	2730	2391	858	858
query18	3236	404	397	397
query19	202	141	146	141
query20	82	72	74	72
query21	182	89	91	89
query22	5292	4932	5110	4932
query23	32713	31756	32091	31756
query24	6781	6576	6467	6467
query25	515	427	422	422
query26	486	158	157	157
query27	1704	299	297	297
query28	6132	2236	2217	2217
query29	2890	2797	2708	2708
query30	241	162	160	160
query31	906	728	751	728
query32	67	55	57	55
query33	386	250	242	242
query34	844	469	487	469
query35	1122	896	935	896
query36	1330	1224	1228	1224
query37	87	61	63	61
query38	3056	2935	2912	2912
query39	1382	1314	1312	1312
query40	197	92	91	91
query41	35	32	33	32
query42	80	80	83	80
query43	644	586	623	586
query44	1158	709	714	709
query45	242	226	221	221
query46	1232	973	989	973
query47	1896	1915	1618	1618
query48	976	683	659	659
query49	610	370	347	347
query50	864	573	589	573
query51	4742	4623	4668	4623
query52	98	77	80	77
query53	443	315	303	303
query54	2666	2485	2492	2485
query55	88	71	80	71
query56	216	219	203	203
query57	1180	1110	1066	1066
query58	214	198	188	188
query59	3530	3376	3384	3376
query60	200	191	202	191
query61	82	78	82	78
query62	863	449	523	449
query63	478	335	331	331
query64	2208	1432	1378	1378
query65	3621	3569	3550	3550
query66	760	367	360	360
query67	17326	16928	17316	16928
query68	5646	649	687	649
query69	553	357	354	354
query70	1485	1552	1505	1505
query71	388	303	310	303
query72	6348	3429	3370	3370
query73	734	327	316	316
query74	6296	5822	5855	5822
query75	4355	3679	3716	3679
query76	2990	1156	1183	1156
query77	454	245	248	245
query78	12534	12846	13305	12846
query79	10690	638	636	636
query80	2348	387	389	387
query81	535	232	239	232
query82	599	102	96	96
query83	262	141	137	137
query84	256	67	69	67
query85	680	281	272	272
query86	381	317	299	299
query87	3306	3031	2950	2950
query88	5007	2286	2290	2286
query89	447	293	271	271
query90	1650	211	216	211
query91	152	113	118	113
query92	55	52	50	50
query93	4922	571	637	571
query94	830	204	207	204
query95	1133	1058	1054	1054
query96	634	325	322	322
query97	6389	6444	6397	6397
query98	195	180	176	176
query99	2748	970	1031	970
Total cold run time: 312727 ms
Total hot run time: 204709 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 8c3cdc56d8e795ffefa8c81f757f0801e70b6066 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       22.5 seconds inserted 10000000 Rows, about 444K ops/s

@xiaokang xiaokang merged commit b1955a9 into apache:branch-2.0 Mar 26, 2024
33 of 37 checks passed
@xiaokang
Copy link
Contributor

#32706

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants