Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](RF) fix 'Invalid value' error of RF of datetimev2 type for max value #32696

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Pick from #32649

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@jacktengg
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 22, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.80% (8045/21283)
Line Coverage: 29.46% (65682/222958)
Region Coverage: 28.93% (33806/116871)
Branch Coverage: 24.77% (17351/70036)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4b57030574d8cb33e13485cc9438c7afd16412f5_4b57030574d8cb33e13485cc9438c7afd16412f5/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 51305 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4b57030574d8cb33e13485cc9438c7afd16412f5, data reload: false

------ Round 1 ----------------------------------
q1	17768	4602	4587	4587
q2	2109	160	145	145
q3	10447	1946	2003	1946
q4	10378	1358	1376	1358
q5	8472	4010	4039	4010
q6	254	123	123	123
q7	2090	1608	1638	1608
q8	9290	2835	2850	2835
q9	10959	10629	10629	10629
q10	8741	3633	3571	3571
q11	416	238	248	238
q12	494	301	305	301
q13	18349	4145	4200	4145
q14	352	334	325	325
q15	519	454	458	454
q16	700	599	586	586
q17	1174	1009	1001	1001
q18	7315	6934	7021	6934
q19	1764	1567	1569	1567
q20	539	319	335	319
q21	4581	4241	4279	4241
q22	515	394	382	382
Total cold run time: 117226 ms
Total hot run time: 51305 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4516	4502	4494	4494
q2	339	226	222	222
q3	4243	4210	4332	4210
q4	2830	2826	2855	2826
q5	7174	7093	7059	7059
q6	258	121	116	116
q7	3199	2866	2833	2833
q8	4300	4366	4377	4366
q9	17192	17077	17036	17036
q10	4255	4374	4309	4309
q11	783	711	712	711
q12	1070	851	860	851
q13	7143	3941	3925	3925
q14	448	426	424	424
q15	499	463	456	456
q16	761	688	697	688
q17	3829	3880	3834	3834
q18	8933	8785	8822	8785
q19	1837	1810	1742	1742
q20	2430	2147	2155	2147
q21	8541	8551	8654	8551
q22	1036	992	990	990
Total cold run time: 85616 ms
Total hot run time: 80575 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 201403 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4b57030574d8cb33e13485cc9438c7afd16412f5, data reload: false

query1	915	387	385	385
query2	6540	2121	2167	2121
query3	6919	205	204	204
query4	20632	18037	18091	18037
query5	19723	6603	6515	6515
query6	280	238	233	233
query7	4168	284	293	284
query8	277	256	241	241
query9	3067	2650	2569	2569
query10	401	295	306	295
query11	11552	11018	10918	10918
query12	126	75	67	67
query13	5573	635	630	630
query14	17520	13357	13255	13255
query15	362	230	240	230
query16	6453	279	256	256
query17	1717	1463	869	869
query18	2324	398	401	398
query19	206	134	137	134
query20	77	74	73	73
query21	188	98	92	92
query22	5355	5052	5069	5052
query23	32640	31805	31893	31805
query24	6840	6449	6424	6424
query25	525	414	412	412
query26	514	156	152	152
query27	1842	286	289	286
query28	6132	2239	2217	2217
query29	2843	2800	2661	2661
query30	241	159	167	159
query31	904	758	756	756
query32	60	59	57	57
query33	373	259	243	243
query34	840	463	494	463
query35	1096	904	916	904
query36	1432	1299	1190	1190
query37	90	64	56	56
query38	3112	2891	2931	2891
query39	1335	1341	1322	1322
query40	199	96	86	86
query41	35	31	32	31
query42	84	80	82	80
query43	586	674	666	666
query44	1123	724	726	724
query45	230	226	231	226
query46	1225	984	947	947
query47	1788	1599	1768	1599
query48	959	672	660	660
query49	614	365	353	353
query50	885	609	634	609
query51	4746	4656	4671	4656
query52	78	80	88	80
query53	452	315	310	310
query54	2643	2486	2436	2436
query55	93	83	84	83
query56	191	210	204	204
query57	1159	1132	1134	1132
query58	222	202	186	186
query59	3498	3147	3012	3012
query60	199	181	204	181
query61	85	82	86	82
query62	864	424	500	424
query63	477	325	329	325
query64	2453	1481	1465	1465
query65	3667	3499	3513	3499
query66	763	374	362	362
query67	15512	15088	15004	15004
query68	8621	663	695	663
query69	565	352	361	352
query70	1643	1572	1594	1572
query71	397	310	305	305
query72	6430	3475	3419	3419
query73	729	316	327	316
query74	6331	5937	5876	5876
query75	5153	3684	3680	3680
query76	5256	1173	1213	1173
query77	810	261	244	244
query78	12582	12122	11904	11904
query79	8555	642	639	639
query80	1394	393	390	390
query81	492	241	230	230
query82	1678	101	93	93
query83	159	134	141	134
query84	253	67	65	65
query85	868	283	275	275
query86	328	332	293	293
query87	3242	3020	2983	2983
query88	4929	2346	2339	2339
query89	378	272	268	268
query90	1933	192	205	192
query91	152	117	114	114
query92	58	47	48	47
query93	6458	552	561	552
query94	695	200	206	200
query95	1103	1068	1046	1046
query96	633	337	328	328
query97	6439	6303	6358	6303
query98	188	179	176	176
query99	2939	985	954	954
Total cold run time: 311415 ms
Total hot run time: 201403 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 4b57030574d8cb33e13485cc9438c7afd16412f5 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       22.4 seconds inserted 10000000 Rows, about 446K ops/s

@xiaokang xiaokang merged commit 200251b into apache:branch-2.0 Mar 22, 2024
24 of 28 checks passed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants