Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pick 2.0](inverted index) fix inappropriate use of macro in inverted index fs directory error process (#32472) #32647

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

airborne12
Copy link
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@airborne12
Copy link
Member Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.80% (8045/21283)
Line Coverage: 29.46% (65682/222958)
Region Coverage: 28.93% (33807/116871)
Branch Coverage: 24.78% (17355/70036)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d97b87be340441e77523fa5e8d0ec89d41bdeb1b_d97b87be340441e77523fa5e8d0ec89d41bdeb1b/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 49937 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d97b87be340441e77523fa5e8d0ec89d41bdeb1b, data reload: false

------ Round 1 ----------------------------------
q1	17567	4415	4393	4393
q2	2037	149	139	139
q3	10553	1916	1920	1916
q4	10340	1244	1316	1244
q5	8842	3930	3918	3918
q6	234	125	120	120
q7	2014	1567	1604	1567
q8	9285	2710	2707	2707
q9	10816	10519	10396	10396
q10	8646	3499	3492	3492
q11	420	248	237	237
q12	459	306	300	300
q13	18361	3967	4033	3967
q14	348	332	333	332
q15	512	464	461	461
q16	690	588	606	588
q17	1112	969	932	932
q18	7208	6874	6976	6874
q19	1665	1605	1550	1550
q20	537	299	310	299
q21	4467	4112	4120	4112
q22	502	393	395	393
Total cold run time: 116615 ms
Total hot run time: 49937 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4337	4306	4344	4306
q2	342	226	216	216
q3	4165	4114	4139	4114
q4	2765	2742	2724	2724
q5	7244	7161	7146	7146
q6	235	119	116	116
q7	3297	2868	2844	2844
q8	4365	4448	4532	4448
q9	17131	16993	17085	16993
q10	4171	4261	4227	4227
q11	749	677	677	677
q12	1040	842	843	842
q13	6405	3785	3760	3760
q14	444	436	425	425
q15	498	449	447	447
q16	760	709	709	709
q17	3858	3834	3922	3834
q18	8880	8770	8910	8770
q19	1692	1699	1615	1615
q20	2417	2167	2145	2145
q21	8508	8454	8389	8389
q22	1028	955	972	955
Total cold run time: 84331 ms
Total hot run time: 79702 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 201980 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d97b87be340441e77523fa5e8d0ec89d41bdeb1b, data reload: false

query1	915	386	381	381
query2	6529	2038	2103	2038
query3	6914	201	201	201
query4	21405	18071	18082	18071
query5	19733	6527	6549	6527
query6	299	218	226	218
query7	4169	311	303	303
query8	252	225	234	225
query9	3129	2682	2594	2594
query10	428	281	287	281
query11	11305	10757	10760	10757
query12	116	75	77	75
query13	5585	640	611	611
query14	17597	13683	13340	13340
query15	365	231	238	231
query16	6444	274	264	264
query17	1727	1447	880	880
query18	2305	411	402	402
query19	203	144	145	144
query20	80	75	73	73
query21	187	98	91	91
query22	5117	5152	5125	5125
query23	32319	31994	31932	31932
query24	7097	6546	6460	6460
query25	532	421	424	421
query26	517	165	156	156
query27	1914	292	301	292
query28	6125	2246	2226	2226
query29	2999	2755	2699	2699
query30	242	164	159	159
query31	906	714	738	714
query32	64	58	57	57
query33	389	253	256	253
query34	848	474	479	474
query35	1105	929	887	887
query36	1255	1393	1220	1220
query37	91	60	62	60
query38	3123	2962	2942	2942
query39	1376	1309	1324	1309
query40	204	90	88	88
query41	34	33	40	33
query42	91	82	89	82
query43	699	633	602	602
query44	1218	727	728	727
query45	244	231	233	231
query46	1230	986	988	986
query47	1797	1779	1919	1779
query48	971	680	663	663
query49	610	377	378	377
query50	877	590	628	590
query51	4769	4719	4681	4681
query52	92	87	87	87
query53	439	320	320	320
query54	2666	2456	2462	2456
query55	83	91	81	81
query56	204	190	204	190
query57	1186	1092	1056	1056
query58	213	206	212	206
query59	3528	3156	3270	3156
query60	205	194	203	194
query61	82	80	79	79
query62	838	497	528	497
query63	470	335	335	335
query64	2553	1508	1410	1410
query65	3640	3568	3544	3544
query66	796	365	363	363
query67	15650	16596	15418	15418
query68	8227	642	677	642
query69	566	331	340	331
query70	1706	1478	1368	1368
query71	387	299	310	299
query72	6449	3508	3414	3414
query73	730	323	326	323
query74	6303	5941	5834	5834
query75	4557	3845	3727	3727
query76	4683	1167	1180	1167
query77	558	246	255	246
query78	12618	11698	11635	11635
query79	9012	647	643	643
query80	2725	388	383	383
query81	524	228	229	228
query82	1483	99	93	93
query83	174	131	128	128
query84	259	69	68	68
query85	1339	298	278	278
query86	356	309	312	309
query87	3208	3040	2976	2976
query88	5245	2368	2348	2348
query89	387	270	292	270
query90	1780	210	212	210
query91	159	115	114	114
query92	56	51	50	50
query93	6154	586	614	586
query94	864	208	209	208
query95	1111	1066	1068	1066
query96	641	332	337	332
query97	6399	6404	6310	6310
query98	194	173	169	169
query99	2963	901	958	901
Total cold run time: 312912 ms
Total hot run time: 201980 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d97b87be340441e77523fa5e8d0ec89d41bdeb1b with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       22.4 seconds inserted 10000000 Rows, about 446K ops/s

@xiaokang xiaokang merged commit cff185d into apache:branch-2.0 Mar 21, 2024
22 of 27 checks passed
@xiaokang
Copy link
Contributor

#32472

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants