[fix] Fix unrecognized column name delete handler #32429 #32404
Conversation
|
Thank you for your contribution to Apache Doris. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| if (!matched) return false; |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| if (!matched) return false; | |
| if (!matched) { return false; | |
| } |
| {R"(@a*<<10086)" , true, gen_cond(R"(@a*)" , "<<", R"(10086)" )}, // column ends with * | ||
| {R"(*a=b)" , false, gen_cond(R"(*a)" , "=" , R"(b)" )}, // starts with * | ||
| {R"(a*a>>WTF(10086))" , true, gen_cond(R"(a*a)" , ">>", R"(WTF(10086))")}, // function | ||
| {R"(a-b IS NULL)" , true, gen_cond(R"(a-b)" , "IS", R"(NULL)" )}, // - in col name and test IS NULL |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| {R"(a-b IS NULL)" , true, gen_cond(R"(a-b)" , "IS", R"(NULL)" )}, // - in col name and test IS NULL | |
| << cond_str; { | |
| } |
| {R"(abc>>b)" , true, gen_cond(R"(abc)" , ">>", R"(b)" )}, // normal case | ||
| {R"(abc<<b)" , true, gen_cond(R"(abc)" , "<<", R"(b)" )}, // normal case | ||
| {R"(abc!='b')" , true, gen_cond(R"(abc)" , "!=", R"(b)" )}, // value surrounded by ' | ||
| {R"(@a*<<10086)" , true, gen_cond(R"(@a*)" , "<<", R"(10086)" )}, // column ends with * |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| {R"(@a*<<10086)" , true, gen_cond(R"(@a*)" , "<<", R"(10086)" )}, // column ends with * | |
| exp_succ) { EXPECT_EQ(parsed_cond, exp_cond) << " unexpected result, cond_str: " << cond_str; | |
| } |
gavinchou
force-pushed
the
gavin-fix-delete-handler
branch
from
ee27528
to
339f17e
Compare
| {R"(abc>>b)" , true, gen_cond(R"(abc)" , ">>", R"(b)" )}, // normal case | ||
| {R"(abc<<b)" , true, gen_cond(R"(abc)" , "<<", R"(b)" )}, // normal case | ||
| {R"(abc!='b')" , true, gen_cond(R"(abc)" , "!=", R"(b)" )}, // value surrounded by ' | ||
| {R"(abc=)" , true, gen_cond(R"(abc)" , "=" , R"()" )}, // missing value, it means not to be parsed succefully, how every it's a ignorable bug |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| {R"(abc=)" , true, gen_cond(R"(abc)" , "=" , R"()" )}, // missing value, it means not to be parsed succefully, how every it's a ignorable bug | |
| exp_succ) { EXPECT_EQ(parsed_cond, exp_cond) << " unexpected result, cond_str: " << cond_str; | |
| } |
|
run buildall |
gavinchou
changed the title
gavinchou
force-pushed
the
gavin-fix-delete-handler
branch
from
339f17e
to
2df21c7
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
gavinchou
force-pushed
the
gavin-fix-delete-handler
branch
from
2df21c7
to
eb82e35
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
符串持久化了, 然后在使用的时候通过正则提取字段名 比较符号 以及值来还原
predicate. 这个序列化和正则匹配的过程是非常tricky并且是不鲁棒的.
但是为了保证兼容, master分支最好也修一下(需要单独提PR, 因为不一样了)
master PR #32429