Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](function) support atan2 math function #30672

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

rohitrs1983
Copy link
Contributor

Proposed changes

Issue Number: close #30671

support atan2 math function.
image

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@HappenLee
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 36634 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ee667b08e91c5edb6593c7df9341bf77d04cf88, data reload: false

------ Round 1 ----------------------------------
q1	17636	4922	4426	4426
q2	2040	140	130	130
q3	10662	895	930	895
q4	4654	660	704	660
q5	7692	2784	2793	2784
q6	184	118	120	118
q7	1116	737	695	695
q8	9248	1949	2032	1949
q9	7187	6301	6288	6288
q10	8075	2434	2426	2426
q11	410	193	198	193
q12	711	279	282	279
q13	18033	3343	3303	3303
q14	270	252	238	238
q15	534	486	489	486
q16	459	399	399	399
q17	936	552	520	520
q18	6665	5879	6023	5879
q19	1569	1363	1348	1348
q20	610	349	324	324
q21	6877	3001	3019	3001
q22	819	293	306	293
Total cold run time: 106387 ms
Total hot run time: 36634 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4480	4438	4357	4357
q2	317	229	229	229
q3	2985	2823	2803	2803
q4	1820	1638	1589	1589
q5	5126	5262	5240	5240
q6	189	117	114	114
q7	2143	1722	1754	1722
q8	3091	3217	3272	3217
q9	8315	8250	8304	8250
q10	5886	3609	3588	3588
q11	548	459	450	450
q12	734	588	580	580
q13	12203	3089	3085	3085
q14	287	253	250	250
q15	537	484	484	484
q16	520	451	449	449
q17	1853	1673	1650	1650
q18	7904	7653	7497	7497
q19	10930	1535	1491	1491
q20	2165	1922	1900	1900
q21	4739	4551	4584	4551
q22	549	451	466	451
Total cold run time: 77321 ms
Total hot run time: 53947 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.17% (8625/23847)
Line Coverage: 28.22% (70534/249900)
Region Coverage: 27.24% (36402/133622)
Branch Coverage: 24.03% (18645/77582)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9ee667b08e91c5edb6593c7df9341bf77d04cf88_9ee667b08e91c5edb6593c7df9341bf77d04cf88/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 174998 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ee667b08e91c5edb6593c7df9341bf77d04cf88, data reload: false

query1	939	337	322	322
query2	6562	2038	1950	1950
query3	6702	198	196	196
query4	31690	22044	22051	22044
query5	4462	357	418	357
query6	252	153	150	150
query7	4603	259	261	259
query8	238	166	185	166
query9	9109	2307	2283	2283
query10	422	202	199	199
query11	18362	15351	15381	15351
query12	114	66	63	63
query13	1618	372	370	370
query14	10339	7353	6981	6981
query15	233	175	177	175
query16	7518	256	247	247
query17	1904	493	467	467
query18	1929	253	247	247
query19	347	133	132	132
query20	72	62	70	62
query21	199	130	125	125
query22	5082	4789	4702	4702
query23	31192	30573	30606	30573
query24	10423	2748	2731	2731
query25	512	321	305	305
query26	709	134	140	134
query27	2116	285	283	283
query28	6002	1881	1865	1865
query29	908	613	598	598
query30	277	131	137	131
query31	899	695	714	695
query32	92	53	50	50
query33	628	205	204	204
query34	882	445	466	445
query35	903	834	777	777
query36	1128	1025	956	956
query37	100	61	66	61
query38	3367	3336	3303	3303
query39	1352	1312	1278	1278
query40	203	87	86	86
query41	41	35	36	35
query42	94	90	90	90
query43	529	514	507	507
query44	1035	721	736	721
query45	204	187	184	184
query46	1058	671	649	649
query47	1839	1626	1647	1626
query48	401	318	313	313
query49	1281	295	289	289
query50	687	319	301	301
query51	5370	5159	5140	5140
query52	87	84	82	82
query53	323	249	260	249
query54	279	180	183	180
query55	80	75	77	75
query56	193	160	168	160
query57	1010	935	908	908
query58	183	150	157	150
query59	2443	2475	2278	2278
query60	826	190	171	171
query61	90	83	83	83
query62	863	355	383	355
query63	283	256	274	256
query64	5142	3693	3202	3202
query65	3250	3233	3219	3219
query66	944	310	309	309
query67	14563	14238	14248	14238
query68	5403	497	494	494
query69	475	310	301	301
query70	1275	1252	1247	1247
query71	402	206	203	203
query72	6064	3133	2839	2839
query73	682	317	323	317
query74	6711	6221	6321	6221
query75	2983	2337	2269	2269
query76	3593	958	941	941
query77	360	226	222	222
query78	9161	8737	8592	8592
query79	3021	488	493	488
query80	2086	309	302	302
query81	530	197	200	197
query82	839	87	76	76
query83	303	120	106	106
query84	289	73	77	73
query85	2171	327	313	313
query86	472	314	279	279
query87	3488	3302	3284	3284
query88	3927	2169	2176	2169
query89	431	347	359	347
query90	1908	184	182	182
query91	145	116	115	115
query92	49	42	42	42
query93	3813	449	437	437
query94	1300	154	155	154
query95	495	450	450	450
query96	618	315	311	311
query97	4245	4094	4127	4094
query98	209	189	186	186
query99	1138	665	654	654
Total cold run time: 286073 ms
Total hot run time: 174998 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9ee667b08e91c5edb6593c7df9341bf77d04cf88, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.02
query3	0.22	0.06	0.06
query4	1.68	0.10	0.10
query5	0.54	0.52	0.52
query6	1.21	0.63	0.67
query7	0.02	0.01	0.02
query8	0.04	0.02	0.02
query9	0.54	0.49	0.51
query10	0.55	0.57	0.57
query11	0.11	0.09	0.08
query12	0.10	0.09	0.09
query13	0.60	0.61	0.61
query14	0.79	0.80	0.80
query15	0.80	0.78	0.77
query16	0.37	0.39	0.40
query17	1.06	1.03	1.05
query18	0.24	0.27	0.24
query19	1.91	1.79	1.82
query20	0.01	0.00	0.01
query21	15.41	0.58	0.60
query22	2.61	2.42	1.95
query23	17.45	1.02	0.67
query24	2.28	1.59	1.56
query25	0.37	0.21	0.19
query26	0.65	0.13	0.13
query27	0.04	0.04	0.05
query28	10.34	0.84	0.84
query29	12.54	3.21	3.16
query30	0.64	0.47	0.50
query31	2.79	0.34	0.36
query32	3.35	0.47	0.48
query33	3.21	3.21	3.26
query34	15.95	4.31	4.28
query35	4.28	4.34	4.26
query36	1.11	1.05	1.05
query37	0.07	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.01	0.01
query40	0.16	0.12	0.12
query41	0.06	0.02	0.02
query42	0.02	0.01	0.01
query43	0.02	0.02	0.02
Total cold run time: 104.3 s
Total hot run time: 31.7 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9ee667b08e91c5edb6593c7df9341bf77d04cf88 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       13.6 seconds inserted 10000000 Rows, about 735K ops/s

Copy link
Collaborator

@LemonLiTree LemonLiTree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Feb 4, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Feb 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 4, 2024
@HappenLee HappenLee merged commit d1923cd into apache:master Feb 4, 2024
29 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support atan2 math function
4 participants