-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[branch-2.0](migrate disk) fix migrate disk lost data during publish version #29887 #30546
[branch-2.0](migrate disk) fix migrate disk lost data during publish version #29887 #30546
Conversation
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -19,9 +19,11 @@ | |||
|
|||
#include <atomic> | |||
#include <boost/lexical_cast.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'boost/lexical_cast.hpp' file not found [clang-diagnostic-error]
#include <boost/lexical_cast.hpp>
^
run buildall |
TPC-H: Total hot run time: 50228 ms
|
TPC-DS: Total hot run time: 238100 ms
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.42 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
pick: #29887
Tablet migrate disk may cause lost data. For example, suppose the old tablet's version is 10, it's just publish txn on version 11. At then comes a migrate disk task. After the old tablet just finish publish txn 11, but before it add rowset( version = 11). For the migrating task, the old tablet had no txn now, so the new tablet will copy the old tablet's data(old tablet's version is still 10). After copying, it will delete the old tablet, and replace it with the new tablet.
So data whose version is 11 will be lost.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...