-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhencement](segcompaction) cancel inflight segcompaction tasks faster when load finish #28901
Merged
dataroaring
merged 1 commit into
apache:master
from
freemandealer:segcompaction_long_tail
Dec 28, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -997,17 +997,22 @@ Status StorageEngine::submit_compaction_task(TabletSharedPtr tablet, CompactionT | |||||
return _submit_compaction_task(tablet, compaction_type, force); | ||||||
} | ||||||
|
||||||
Status StorageEngine::_handle_seg_compaction(SegcompactionWorker* worker, | ||||||
SegCompactionCandidatesSharedPtr segments) { | ||||||
Status StorageEngine::_handle_seg_compaction(std::shared_ptr<SegcompactionWorker> worker, | ||||||
SegCompactionCandidatesSharedPtr segments, | ||||||
uint64_t submission_time) { | ||||||
// note: be aware that worker->_writer maybe released when the task is cancelled | ||||||
uint64_t exec_queue_time = GetCurrentTimeMicros() - submission_time; | ||||||
LOG(INFO) << "segcompaction thread pool queue time(ms): " << exec_queue_time / 1000; | ||||||
worker->compact_segments(segments); | ||||||
// return OK here. error will be reported via BetaRowsetWriter::_segcompaction_status | ||||||
return Status::OK(); | ||||||
} | ||||||
|
||||||
Status StorageEngine::submit_seg_compaction_task(SegcompactionWorker* worker, | ||||||
Status StorageEngine::submit_seg_compaction_task(std::shared_ptr<SegcompactionWorker> worker, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: method 'submit_seg_compaction_task' can be made static [readability-convert-member-functions-to-static]
Suggested change
|
||||||
SegCompactionCandidatesSharedPtr segments) { | ||||||
return _seg_compaction_thread_pool->submit_func( | ||||||
std::bind<void>(&StorageEngine::_handle_seg_compaction, this, worker, segments)); | ||||||
uint64_t submission_time = GetCurrentTimeMicros(); | ||||||
return _seg_compaction_thread_pool->submit_func(std::bind<void>( | ||||||
&StorageEngine::_handle_seg_compaction, this, worker, segments, submission_time)); | ||||||
} | ||||||
|
||||||
Status StorageEngine::process_index_change_task(const TAlterInvertedIndexReq& request) { | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: method '_handle_seg_compaction' can be made static [readability-convert-member-functions-to-static]