[refactor](stats) Migrate stats framework from master to branch 2.0 #25119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/nereids
area/planner
|
clang-tidy review says "All clean, LGTM! 👍" |
morningman
reviewed
Oct 8, 2023
| // note: when increment meta version, should assign the latest version to VERSION_CURRENT | ||
| public static final int VERSION_CURRENT = VERSION_123; | ||
| public static final int VERSION_CURRENT = VERSION_124; |
There was a problem hiding this comment.
Can not pick to branch 2.0 if meta version is changed
morningman
reviewed
Oct 8, 2023
| @@ -844,6 +846,21 @@ public void readFields(DataInput in) throws IOException { | |||
| isRead = true; | |||
| break; | |||
| } | |||
| case OperationType.OP_UPDATE_TABLE_STATS: { | |||
| data = TableStatsMeta.read(in); | |||
There was a problem hiding this comment.
If we write this new meta data , and downgrade to old version, it may cause problem because the old version can not recognize this kind of meta data.
morningman
reviewed
Oct 8, 2023
| @@ -1091,7 +1091,7 @@ struct TGetBinlogLagResult { | |||
|
|
|||
| struct TUpdateFollowerStatsCacheRequest { | |||
| 1: optional string key; | |||
| 2: optional string colStats; | |||
| 2: list<string> statsRows; | |||
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Kikyou1997
pushed a commit
to Kikyou1997/incubator-doris
that referenced
this pull request
Oct 13, 2023
…er to branch 2.0 (apache#25119)" This reverts commit 4b6ff32.
morningman
pushed a commit
that referenced
this pull request
Oct 13, 2023
…er to branch 2.0 (#25119)" (#25403) This reverts commit 4b6ff32. Co-authored-by: AKIHA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is composed of belowing commits which has been merged to Doirs master:
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...