[func](jsonb)support json_depth function #24801
Conversation
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
LemonLiTree
force-pushed
the
support_json_depth
branch
2 times, most recently
from
68a669c
to
5a9e071
Compare
LemonLiTree
force-pushed
the
support_json_depth
branch
from
5a9e071
to
52c5de5
Compare
|
run buildall |
|
|
||
| * 空数组、空对象或标量的深度为 1。 | ||
| * 仅包含深度为 1 的元素的非空数组的深度为2。 | ||
| * 仅包含深度为 1 的成员值的非空对象的深度为2。 |
There was a problem hiding this comment.
add explanation for depth > 2
| @@ -1771,6 +1771,7 @@ | |||
| [['json_contains'], 'BOOLEAN', ['JSONB', 'JSONB'], 'ALWAYS_NULLABLE'], | |||
| [['json_contains'], 'BOOLEAN', ['JSONB', 'JSONB', 'VARCHAR'], 'ALWAYS_NULLABLE'], | |||
| [['json_contains'], 'BOOLEAN', ['JSONB', 'JSONB', 'STRING'], 'ALWAYS_NULLABLE'], | |||
| [['json_depth'], 'INT', ['JSONB'], 'ALWAYS_NULLABLE'], | |||
There was a problem hiding this comment.
why not depends on argument?
be/src/util/jsonb_document.h
Outdated
| return 1; | ||
| } | ||
| case JsonbType::T_Object: { | ||
| int depth = 1; |
There was a problem hiding this comment.
suggest a better name base_depth
| auto return_type = block.get_data_type(result); | ||
| MutableColumnPtr res = return_type->create_column(); | ||
|
|
||
| //if(jsonb_data_column->) |
| continue; | ||
| } | ||
| auto depth = value->depth(); | ||
| res->insert_data(const_cast<const char*>((char*)&depth), 0); |
There was a problem hiding this comment.
it's unsafe. Add a int32 to column is safe and efficient.
LemonLiTree
force-pushed
the
support_json_depth
branch
from
52c5de5
to
c3e83e5
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| String get_name() const override { return name; } | ||
| static FunctionPtr create() { return std::make_shared<FunctionJsonbDepth>(); } | ||
|
|
||
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { |
There was a problem hiding this comment.
warning: method 'get_return_type_impl' can be made static [readability-convert-member-functions-to-static]
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { | |
| static DataTypePtr get_return_type_impl(const DataTypes& arguments) override { |
|
|
||
| bool use_default_implementation_for_nulls() const override { return false; } | ||
|
|
||
| Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, |
There was a problem hiding this comment.
warning: method 'execute_impl' can be made static [readability-convert-member-functions-to-static]
| Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, | |
| static Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, |
| Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, | ||
| size_t result, size_t input_rows_count) const override { |
There was a problem hiding this comment.
warning: method 'execute_impl' can be made static [readability-convert-member-functions-to-static]
| Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, | |
| size_t result, size_t input_rows_count) const override { | |
| static Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, | |
| size_t result, size_t input_rows_count) override { |
|
run buildall |
1 similar comment
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
1 similar comment
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
LemonLiTree
force-pushed
the
support_json_depth
branch
from
722c271
to
401ccb1
Compare
|
run buildall |
TPC-H: Total hot run time: 38737 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 186313 ms |
ClickBench: Total hot run time: 30.33 s |
|
run buildall |
TPC-H: Total hot run time: 38574 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 185648 ms |
ClickBench: Total hot run time: 29.97 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
| * ScalarFunction 'json_depth'. This class is generated by GenerateFunction. | ||
| */ | ||
| public class JsonDepth extends ScalarFunction | ||
| implements BinaryExpression, ExplicitlyCastableSignature, PropagateNullable { |
There was a problem hiding this comment.
jsonDepth should be UnaryExpression
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...