update

apache · Oct 10, 2024 · f3a4f93 · f3a4f93
1 parent de8cb0a
commit f3a4f93
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/be/src/pipeline/exec/nested_loop_join_probe_operator.cpp b/be/src/pipeline/exec/nested_loop_join_probe_operator.cpp
@@ -390,6 +390,7 @@ void NestedLoopJoinProbeLocalState::_process_left_child_block(
                     .get_data()
                     .resize_fill(origin_sz + max_added_rows, 0);
         } else {
+            // TODO: for cross join, maybe could insert one row, and wrap for a const column
             dst_columns[i]->insert_many_from(*src_column.column, _left_block_pos, max_added_rows);
         }
     }

diff --git a/be/src/vec/columns/column_decimal.cpp b/be/src/vec/columns/column_decimal.cpp
@@ -305,9 +305,7 @@ void ColumnDecimal<T>::insert_many_from(const IColumn& src, size_t position, siz
     auto old_size = data.size();
     data.resize(old_size + length);
     auto& vals = assert_cast<const Self&>(src).get_data();
-    for (auto i = 0; i < length; ++i) {
-        data[old_size + i] = vals[position];
-    }
+    std::fill(&data[old_size], &data[old_size + length], vals[position]);
 }
 
 template <typename T>

diff --git a/be/src/vec/columns/column_vector.cpp b/be/src/vec/columns/column_vector.cpp
@@ -436,9 +436,7 @@ void ColumnVector<T>::insert_many_from(const IColumn& src, size_t position, size
     auto old_size = data.size();
     data.resize(old_size + length);
     auto& vals = assert_cast<const Self&>(src).get_data();
-    for (auto i = 0; i < length; ++i) {
-        data[old_size + i] = vals[position];
-    }
+    std::fill(&data[old_size], &data[old_size + length], vals[position]);
 }
 
 template <typename T>