Skip to content

Commit

Permalink
remove schema from delta_writer
Browse files Browse the repository at this point in the history
  • Loading branch information
kaijchen committed Jun 29, 2023
1 parent 426f24a commit f196530
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions be/src/olap/delta_writer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
#include "olap/rowset/rowset_writer.h"
#include "olap/rowset/rowset_writer_context.h"
#include "olap/rowset/segment_v2/inverted_index_desc.h"
#include "olap/schema.h"
#include "olap/schema_change.h"
#include "olap/storage_engine.h"
#include "olap/tablet_manager.h"
Expand Down Expand Up @@ -203,7 +202,6 @@ Status DeltaWriter::init() {
_delete_bitmap);
RETURN_IF_ERROR(_tablet->create_rowset_writer(context, &_rowset_writer));

_schema.reset(new Schema(_tablet_schema));
_reset_mem_table();

// create flush handler
Expand Down
2 changes: 0 additions & 2 deletions be/src/olap/delta_writer.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ namespace doris {
class FlushToken;
class MemTable;
class MemTracker;
class Schema;
class StorageEngine;
class TupleDescriptor;
class SlotDescriptor;
Expand Down Expand Up @@ -158,7 +157,6 @@ class DeltaWriter {
std::unique_ptr<RowsetWriter> _rowset_writer;
// TODO: Recheck the lifetime of _mem_table, Look should use unique_ptr
std::unique_ptr<MemTable> _mem_table;
std::unique_ptr<Schema> _schema;
//const TabletSchema* _tablet_schema;
// tablet schema owned by delta writer, all write will use this tablet schema
// it's build from tablet_schema(stored when create tablet) and OlapTableSchema
Expand Down

0 comments on commit f196530

Please sign in to comment.