resolve gavin comment

apache · Apr 17, 2024 · eeedc93 · eeedc93
1 parent 020af21
commit eeedc93
Showing 1 changed file with 19 additions and 19 deletions.
diff --git a/be/src/cloud/injection_point_action.cpp b/be/src/cloud/injection_point_action.cpp
@@ -45,11 +45,11 @@ void register_suites() {
         sp->set_call_back("new_cumulative_point", [](auto&& args) {
             auto output_rowset = try_any_cast<Rowset*>(args[0]);
             auto last_cumulative_point = try_any_cast<int64_t>(args[1]);
-            auto pair = try_any_cast<std::pair<int64_t, bool>*>(args.back());
-            pair->first = output_rowset->start_version() == last_cumulative_point
-                                  ? output_rowset->end_version() + 1
-                                  : last_cumulative_point;
-            pair->second = true;
+            auto& [ret_vault, should_ret] = *try_any_cast<std::pair<int64_t, bool>*>(args.back());
+            ret_vault = output_rowset->start_version() == last_cumulative_point
+                                ? output_rowset->end_version() + 1
+                                : last_cumulative_point;
+            should_ret = true;
         });
     });
     suite_map.emplace("test_s3_file_writer", [] {
@@ -60,10 +60,10 @@ void register_suites() {
             std::this_thread::sleep_for(std::chrono::seconds(random_sleep_time_second));
         });
         sp->set_call_back("UploadFileBuffer::upload_to_local_file_cache_inject", [](auto&& args) {
-            auto pair = try_any_cast<std::pair<Status, bool>*>(args.back());
-            pair->first =
+            auto& [ret_status, should_ret] = *try_any_cast<std::pair<Status, bool>*>(args.back());
+            ret_status =
                     Status::IOError<false>("failed to write into file cache due to inject error");
-            pair->second = true;
+            should_ret = true;
         });
     });
     suite_map.emplace("test_storage_vault", [] {
@@ -74,23 +74,23 @@ void register_suites() {
             std::this_thread::sleep_for(std::chrono::seconds(random_sleep_time_second));
         });
         sp->set_call_back("HdfsFileWriter::appendv_error", [](auto&& args) {
-            auto pair = try_any_cast<std::pair<Status, bool>*>(args.back());
-            pair->second = true;
+            auto& [_, should_ret] = *try_any_cast<std::pair<Status, bool>*>(args.back());
+            should_ret = true;
         });
         sp->set_call_back("HdfsFileWriter::close_hdfsFlush", [](auto&& args) {
-            auto pair = try_any_cast<std::pair<int, bool>*>(args.back());
-            pair->first = -1;
-            pair->second = true;
+            auto& [ret_value, should_ret] = *try_any_cast<std::pair<int, bool>*>(args.back());
+            ret_value = -1;
+            should_ret = true;
         });
         sp->set_call_back("HdfsFileWriter::close_hdfsCloseFile", [](auto&& args) {
-            auto pair = try_any_cast<std::pair<int, bool>*>(args.back());
-            pair->first = -1;
-            pair->second = true;
+            auto& [ret_value, should_ret] = *try_any_cast<std::pair<int, bool>*>(args.back());
+            ret_value = -1;
+            should_ret = true;
         });
         sp->set_call_back("HdfsFileReader:read_error", [](auto&& args) {
-            auto pair = try_any_cast<std::pair<Status, bool>*>(args.back());
-            pair->first = Status::InternalError("read hdfs error");
-            pair->second = true;
+            auto& [ret_status, should_ret] = *try_any_cast<std::pair<Status, bool>*>(args.back());
+            ret_status = Status::InternalError("read hdfs error");
+            should_ret = true;
         });
     });
 }