Skip to content

Commit

Permalink
[exec](column) change some complex column move to noexcept
Browse files Browse the repository at this point in the history
  • Loading branch information
HappenLee committed Mar 28, 2024
1 parent 2ee8bf1 commit c87381c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
4 changes: 2 additions & 2 deletions be/src/olap/hll.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class HyperLogLog {
}
}

HyperLogLog(HyperLogLog&& other) {
HyperLogLog(HyperLogLog&& other) noexcept {
this->_type = other._type;
switch (other._type) {
case HLL_DATA_EMPTY:
Expand All @@ -131,7 +131,7 @@ class HyperLogLog {
}
}

HyperLogLog& operator=(HyperLogLog&& other) {
HyperLogLog& operator=(HyperLogLog&& other) noexcept {
if (this != &other) {
if (_registers != nullptr) {
delete[] _registers;
Expand Down
4 changes: 2 additions & 2 deletions be/src/util/bitmap_value.h
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ class BitmapValue {
}
}

BitmapValue(BitmapValue&& other) {
BitmapValue(BitmapValue&& other) noexcept {
_type = other._type;
switch (other._type) {
case EMPTY:
Expand Down Expand Up @@ -1265,7 +1265,7 @@ class BitmapValue {
return buf;
}

BitmapValue& operator=(BitmapValue&& other) {
BitmapValue& operator=(BitmapValue&& other) noexcept {
if (this == &other) {
return *this;
}
Expand Down
5 changes: 5 additions & 0 deletions be/src/util/quantile_state.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ class QuantileState {
QuantileState();
explicit QuantileState(float compression);
explicit QuantileState(const Slice& slice);
QuantileState& operator=(const QuantileState& other) noexcept = default;
QuantileState(const QuantileState& other) noexcept = default;
QuantileState& operator=(QuantileState&& other) noexcept = default;
QuantileState(QuantileState&& other) noexcept = default;

void set_compression(float compression);
bool deserialize(const Slice& slice);
size_t serialize(uint8_t* dst) const;
Expand Down

0 comments on commit c87381c

Please sign in to comment.