Skip to content

Commit

Permalink
[improvement](binlog) Reduce AlterJobV2/TruncateTable binlog size (#3…
Browse files Browse the repository at this point in the history
…0505) (#30567)

Signed-off-by: Jack Drogon <[email protected]>
  • Loading branch information
JackDrogon authored Jan 30, 2024
1 parent b69344f commit 50a10c8
Show file tree
Hide file tree
Showing 4 changed files with 113 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ public void setFinishedTimeMs(long finishedTimeMs) {
this.finishedTimeMs = finishedTimeMs;
}

public String getRawSql() {
return rawSql;
}

// /api/debug_point/add/{name}?value=100
private void stateWait(final String name) {
long waitTimeMs = DebugPointUtil.getDebugParamOrDefault(name, 0);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

package org.apache.doris.binlog;

import org.apache.doris.alter.AlterJobV2;
import org.apache.doris.persist.gson.GsonUtils;

import com.google.gson.annotations.SerializedName;

public class AlterJobRecord {
@SerializedName(value = "type")
private AlterJobV2.JobType type;
@SerializedName(value = "dbId")
private long dbId;
@SerializedName(value = "tableId")
private long tableId;
@SerializedName(value = "tableName")
private String tableName;
@SerializedName(value = "jobId")
private long jobId;
@SerializedName(value = "jobState")
private AlterJobV2.JobState jobState;
@SerializedName(value = "rawSql")
private String rawSql;

public AlterJobRecord(AlterJobV2 job) {
this.type = job.getType();
this.dbId = job.getDbId();
this.tableId = job.getTableId();
this.tableName = job.getTableName();
this.jobId = job.getJobId();
this.jobState = job.getJobState();
this.rawSql = job.getRawSql();
}

public String toJson() {
return GsonUtils.GSON.toJson(this);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,8 @@ public void addAlterJobV2(AlterJobV2 alterJob, long commitSeq) {
tableIds.add(alterJob.getTableId());
long timestamp = -1;
TBinlogType type = TBinlogType.ALTER_JOB;
String data = alterJob.toJson();
AlterJobRecord alterJobRecord = new AlterJobRecord(alterJob);
String data = alterJobRecord.toJson();

addBinlog(dbId, tableIds, commitSeq, timestamp, type, data, false);
}
Expand Down Expand Up @@ -303,7 +304,8 @@ public void addTruncateTable(TruncateTableInfo info, long commitSeq) {
tableIds.add(info.getTblId());
long timestamp = -1;
TBinlogType type = TBinlogType.TRUNCATE_TABLE;
String data = info.toJson();
TruncateTableRecord record = new TruncateTableRecord(info);
String data = record.toJson();

addBinlog(dbId, tableIds, commitSeq, timestamp, type, data, false);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

package org.apache.doris.binlog;

import org.apache.doris.persist.TruncateTableInfo;
import org.apache.doris.persist.gson.GsonUtils;

import com.google.gson.annotations.SerializedName;

public class TruncateTableRecord {
@SerializedName(value = "dbId")
private long dbId;
@SerializedName(value = "db")
private String db;
@SerializedName(value = "tblId")
private long tblId;
@SerializedName(value = "table")
private String table;
@SerializedName(value = "isEntireTable")
private boolean isEntireTable = false;
@SerializedName(value = "rawSql")
private String rawSql = "";

public TruncateTableRecord(TruncateTableInfo info) {
this.dbId = info.getDbId();
this.db = info.getDb();
this.tblId = info.getTblId();
this.table = info.getTable();
this.isEntireTable = info.isEntireTable();
this.rawSql = info.getRawSql();
}

public String toJson() {
return GsonUtils.GSON.toJson(this);
}
}

0 comments on commit 50a10c8

Please sign in to comment.