Skip to content

Commit

Permalink
[fix](regression)Add log for iceberg stats case. (#41301)
Browse files Browse the repository at this point in the history
Add log for iceberg stats case.
  • Loading branch information
Jibing-Li authored Sep 25, 2024
1 parent 298831a commit 41a7a4f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public ProcNodeInterface lookup(String catalogIdStr) throws AnalysisException {

CatalogIf catalog = env.getCatalogMgr().getCatalog(catalogId);
if (catalog == null) {
throw new AnalysisException("Catalog " + catalogIdStr + " does not exist");
throw new AnalysisException("Catalog " + catalogIdStr + " does not exist. Id " + catalogId);
}

return new DbsProcDir(env, catalog);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ private void addCatalog(CatalogIf catalog) {

private CatalogIf removeCatalog(long catalogId) {
CatalogIf catalog = idToCatalog.remove(catalogId);
LOG.info("Removed catalog with id {}, name {}", catalogId, catalog == null ? "N/A" : catalog.getName());
if (catalog != null) {
catalog.onClose();
nameToCatalog.remove(catalog.getName());
Expand Down
1 change: 1 addition & 0 deletions regression-test/plugins/plugins_get_ids_from_proc.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Suite.metaClass.get_catalog_id = {String catalog_name /* param */ ->
}
}
log.info("get catalogid: " + catalog_id)
log.info("show proc info: " + catalogs)
return catalog_id
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ suite("test_iceberg_statistics", "p0,external,doris,external_docker,external_doc
"s3.region" = "us-east-1"
);"""

def result = sql """show frontends;"""
logger.info("Frontends info: " + result)

def table_id_mor = get_table_id(catalog_name, db_name, "sample_mor_parquet")
def table_id_cow = get_table_id(catalog_name, db_name, "sample_cow_parquet")

Expand All @@ -54,4 +57,3 @@ suite("test_iceberg_statistics", "p0,external,doris,external_docker,external_doc
}
}
}

0 comments on commit 41a7a4f

Please sign in to comment.