-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[fix](mtmv) Fix duplicate column name not check when create materiali…
…zed view (#40658) ## Proposed changes This is brought by #26146 If create materialized view as following, Should fail, because has the duplicated column name `o_orderdatE` and `o_orderdate`. But now can create materialized view successfully. the pr fix this. ```sql CREATE MATERIALIZED VIEW mv_1 BUILD IMMEDIATE REFRESH AUTO ON MANUAL partition by(o_orderdate) DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select o_orderdatE, o_shippriority, o_comment, o_orderdate, sum(o_totalprice) as sum_total, max(o_totalpricE) as max_total, min(o_totalprice) as min_total, count(*) as count_all, bitmap_union(to_bitmap(case when o_shippriority > 1 and o_orderkey IN (1, 3) then o_custkey else null end)) cnt_1, bitmap_union(to_bitmap(case when o_shippriority > 2 and o_orderkey IN (2) then o_custkey else null end)) as cnt_2 from (select * from orders) as t1 group by o_orderdatE, o_shippriority, o_comment, o_orderdate; ```
- Loading branch information
Showing
4 changed files
with
119 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
regression-test/suites/mtmv_p0/same_column_name_check/same_column_name_check.groovy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| suite("same_column_name_check") { | ||
| String db = context.config.getDbNameByFile(context.file) | ||
| sql "use ${db}" | ||
| sql "set runtime_filter_mode=OFF"; | ||
| sql "SET ignore_shape_nodes='PhysicalDistribute,PhysicalProject'" | ||
|
|
||
| sql """ | ||
| drop table if exists orders | ||
| """ | ||
|
|
||
| sql """ | ||
| CREATE TABLE IF NOT EXISTS orders ( | ||
| o_orderkey INTEGER NOT NULL, | ||
| o_custkey INTEGER NOT NULL, | ||
| o_orderstatus CHAR(1) NOT NULL, | ||
| o_totalprice DECIMALV3(15,2) NOT NULL, | ||
| o_orderdate DATE NOT NULL, | ||
| o_orderpriority CHAR(15) NOT NULL, | ||
| o_clerk CHAR(15) NOT NULL, | ||
| o_shippriority INTEGER NOT NULL, | ||
| O_COMMENT VARCHAR(79) NOT NULL | ||
| ) | ||
| DUPLICATE KEY(o_orderkey, o_custkey) | ||
| PARTITION BY RANGE(o_orderdate) ( | ||
| PARTITION `day_2` VALUES LESS THAN ('2023-12-9'), | ||
| PARTITION `day_3` VALUES LESS THAN ("2023-12-11"), | ||
| PARTITION `day_4` VALUES LESS THAN ("2023-12-30") | ||
| ) | ||
| DISTRIBUTED BY HASH(o_orderkey) BUCKETS 3 | ||
| PROPERTIES ( | ||
| "replication_num" = "1" | ||
| ); | ||
| """ | ||
|
|
||
| sql """ | ||
| insert into orders values | ||
| (1, 1, 'o', 9.5, '2023-12-08', 'a', 'b', 1, 'yy'), | ||
| (1, 1, 'o', 10.5, '2023-12-08', 'a', 'b', 1, 'yy'), | ||
| (1, 1, 'o', 10.5, '2023-12-08', 'a', 'b', 1, 'yy'), | ||
| (1, 1, 'o', 10.5, '2023-12-08', 'a', 'b', 1, 'yy'), | ||
| (2, 1, 'o', 11.5, '2023-12-09', 'a', 'b', 1, 'yy'), | ||
| (2, 1, 'o', 11.5, '2023-12-09', 'a', 'b', 1, 'yy'), | ||
| (2, 1, 'o', 11.5, '2023-12-09', 'a', 'b', 1, 'yy'), | ||
| (3, 1, 'o', 12.5, '2023-12-10', 'a', 'b', 1, 'yy'), | ||
| (3, 1, 'o', 12.5, '2023-12-10', 'a', 'b', 1, 'yy'), | ||
| (3, 1, 'o', 12.5, '2023-12-10', 'a', 'b', 1, 'yy'), | ||
| (3, 1, 'o', 33.5, '2023-12-10', 'a', 'b', 1, 'yy'), | ||
| (4, 2, 'o', 43.2, '2023-12-11', 'c','d',2, 'mm'), | ||
| (4, 2, 'o', 43.2, '2023-12-11', 'c','d',2, 'mm'), | ||
| (4, 2, 'o', 43.2, '2023-12-11', 'c','d',2, 'mm'), | ||
| (5, 2, 'o', 56.2, '2023-12-12', 'c','d',2, 'mi'), | ||
| (5, 2, 'o', 56.2, '2023-12-12', 'c','d',2, 'mi'), | ||
| (5, 2, 'o', 56.2, '2023-12-12', 'c','d',2, 'mi'), | ||
| (5, 2, 'o', 1.2, '2023-12-12', 'c','d',2, 'mi'); | ||
| """ | ||
|
|
||
| sql """analyze table orders with sync""" | ||
|
|
||
| sql """DROP MATERIALIZED VIEW IF EXISTS mv_1""" | ||
| test { | ||
| sql """ | ||
| CREATE MATERIALIZED VIEW mv_1 | ||
| BUILD IMMEDIATE REFRESH AUTO ON MANUAL | ||
| partition by(o_orderdate) | ||
| DISTRIBUTED BY RANDOM BUCKETS 2 | ||
| PROPERTIES ('replication_num' = '1') | ||
| AS | ||
| select o_orderdatE, o_shippriority, o_comment, o_orderdate, | ||
| sum(o_totalprice) as sum_total, | ||
| max(o_totalpricE) as max_total, | ||
| min(o_totalprice) as min_total, | ||
| count(*) as count_all, | ||
| bitmap_union(to_bitmap(case when o_shippriority > 1 and o_orderkey IN (1, 3) then o_custkey else null end)) cnt_1, | ||
| bitmap_union(to_bitmap(case when o_shippriority > 2 and o_orderkey IN (2) then o_custkey else null end)) as cnt_2 | ||
| from (select * from orders) as t1 | ||
| group by | ||
| o_orderdatE, | ||
| o_shippriority, | ||
| o_comment, | ||
| o_orderdate; | ||
| """ | ||
| exception "Duplicate column name" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters