Skip to content

Commit

Permalink
fix cmt
Browse files Browse the repository at this point in the history
  • Loading branch information
@zclllyybb
zclllyybb committed May 28, 2024
1 parent 1f0d22b commit 2052124
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 23 deletions.
4 changes: 2 additions & 2 deletions be/src/vec/columns/column.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@

#include <fmt/format.h>
#include <glog/logging.h>
#include <stdint.h>
#include <sys/types.h>

#include <algorithm>
#include <cstdint>
#include <functional>
#include <ostream>
#include <string>
Expand Down Expand Up @@ -692,6 +691,7 @@ struct IsMutableColumns<> {
static const bool value = true;
};

// prefer assert_cast than check_and_get
template <typename Type>
const Type* check_and_get_column(const IColumn& column) {
return typeid_cast<const Type*>(&column);
Expand Down
42 changes: 21 additions & 21 deletions be/src/vec/functions/function_ip.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ static inline bool try_parse_ipv4(const char* pos, Int64& result_value) {

template <IPConvertExceptionMode exception_mode, typename ToColumn>
ColumnPtr convert_to_ipv4(ColumnPtr column, const PaddedPODArray<UInt8>* null_map = nullptr) {
const auto* column_string = check_and_get_column<ColumnString>(column.get());
const auto* column_string = assert_cast<const ColumnString*>(column.get());

size_t column_size = column_string->size();

Expand Down Expand Up @@ -261,7 +261,7 @@ void process_ipv6_column(const ColumnPtr& column, size_t input_rows_count,
auto* begin = reinterpret_cast<char*>(vec_res.data());
auto* pos = begin;

const auto* col = check_and_get_column<T>(column.get());
const auto* col = assert_cast<const T*>(column.get());

for (size_t i = 0; i < input_rows_count; ++i) {
bool is_empty = false;
Expand Down Expand Up @@ -329,7 +329,7 @@ class FunctionIPv6NumToString : public IFunction {

unsigned char ipv6_address_data[IPV6_BINARY_LENGTH];

if (check_and_get_column<ColumnIPv6>(column.get())) {
if (assert_cast<const ColumnIPv6*>(column.get())) {
process_ipv6_column<ColumnIPv6>(column, input_rows_count, vec_res, offsets_res,
null_map, ipv6_address_data);
} else { //ColumnString
Expand Down Expand Up @@ -489,7 +489,7 @@ ColumnPtr convert_to_ipv6(const StringColumnType& string_column,

template <IPConvertExceptionMode exception_mode, typename ToColumn = ColumnIPv6>
ColumnPtr convert_to_ipv6(ColumnPtr column, const PaddedPODArray<UInt8>* null_map = nullptr) {
const auto* column_input_string = check_and_get_column<ColumnString>(column.get());
const auto* column_input_string = assert_cast<const ColumnString*>(column.get());
auto result = detail::convert_to_ipv6<exception_mode, ToColumn>(*column_input_string, null_map);
return result;
}
Expand Down Expand Up @@ -615,8 +615,8 @@ class FunctionIsIPAddressInRange : public IFunction {
unpack_if_const(addr_column_with_type_and_name.column);
const auto& [cidr_column, cidr_const] =
unpack_if_const(cidr_column_with_type_and_name.column);
const auto* str_addr_column = check_and_get_column<ColumnString>(addr_column.get());
const auto* str_cidr_column = check_and_get_column<ColumnString>(cidr_column.get());
const auto* str_addr_column = assert_cast<const ColumnString*>(addr_column.get());
const auto* str_cidr_column = assert_cast<const ColumnString*>(cidr_column.get());

auto col_res = ColumnUInt8::create(input_rows_count, 0);
auto& col_res_data = col_res->get_data();
Expand Down Expand Up @@ -671,21 +671,21 @@ class FunctionIsIPAddressInRangeOld : public IFunction {
if (addr_type.is_nullable()) {
const auto* addr_column_nullable =
assert_cast<const ColumnNullable*>(addr_column.get());
str_addr_column =
check_and_get_column<ColumnString>(addr_column_nullable->get_nested_column());
str_addr_column = assert_cast<const ColumnString*>(
addr_column_nullable->get_nested_column_ptr().get());
null_map_addr = &addr_column_nullable->get_null_map_data();
} else {
str_addr_column = check_and_get_column<ColumnString>(addr_column.get());
str_addr_column = assert_cast<const ColumnString*>(addr_column.get());
}

if (cidr_type.is_nullable()) {
const auto* cidr_column_nullable =
assert_cast<const ColumnNullable*>(cidr_column.get());
str_cidr_column =
check_and_get_column<ColumnString>(cidr_column_nullable->get_nested_column());
str_cidr_column = assert_cast<const ColumnString*>(
cidr_column_nullable->get_nested_column_ptr().get());
null_map_cidr = &cidr_column_nullable->get_null_map_data();
} else {
str_cidr_column = check_and_get_column<ColumnString>(cidr_column.get());
str_cidr_column = assert_cast<const ColumnString*>(cidr_column.get());
}

auto col_res = ColumnUInt8::create(input_rows_count, 0);
Expand Down Expand Up @@ -739,9 +739,9 @@ class FunctionIPv4CIDRToRange : public IFunction {
const auto& [ip_column_ptr, ip_col_const] = unpack_if_const(ip_column.column);
const auto& [cidr_column_ptr, cidr_col_const] = unpack_if_const(cidr_column.column);

const auto* col_ip_column = check_and_get_column<ColumnVector<IPv4>>(ip_column_ptr.get());
const auto* col_ip_column = assert_cast<const ColumnVector<IPv4>*>(ip_column_ptr.get());
const auto* col_cidr_column =
check_and_get_column<ColumnVector<Int16>>(cidr_column_ptr.get());
assert_cast<const ColumnVector<Int16>*>(cidr_column_ptr.get());

const typename ColumnVector<IPv4>::Container& vec_ip_input = col_ip_column->get_data();
const ColumnInt16::Container& vec_cidr_input = col_cidr_column->get_data();
Expand Down Expand Up @@ -843,11 +843,11 @@ class FunctionIPv6CIDRToRange : public IFunction {
ColumnPtr col_res = nullptr;

if (addr_type.is_ipv6()) {
const auto* ipv6_addr_column = check_and_get_column<ColumnIPv6>(addr_column.get());
const auto* ipv6_addr_column = assert_cast<const ColumnIPv6*>(addr_column.get());
col_res = execute_impl<ColumnIPv6>(*ipv6_addr_column, *cidr_col, input_rows_count,
add_col_const, col_const);
} else if (addr_type.is_string()) {
const auto* str_addr_column = check_and_get_column<ColumnString>(addr_column.get());
const auto* str_addr_column = assert_cast<const ColumnString*>(addr_column.get());
col_res = execute_impl<ColumnString>(*str_addr_column, *cidr_col, input_rows_count,
add_col_const, col_const);
} else {
Expand Down Expand Up @@ -965,7 +965,7 @@ class FunctionIsIPv4Compat : public IFunction {
Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
size_t result, size_t input_rows_count) const override {
const ColumnPtr& column = block.get_by_position(arguments[0]).column;
const auto* col_in = check_and_get_column<ColumnString>(column.get());
const auto* col_in = assert_cast<const ColumnString*>(column.get());
DCHECK(col_in != nullptr);

size_t col_size = col_in->size();
Expand Down Expand Up @@ -1007,7 +1007,7 @@ class FunctionIsIPv4Mapped : public IFunction {
Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
size_t result, size_t input_rows_count) const override {
const ColumnPtr& column = block.get_by_position(arguments[0]).column;
const auto* col_in = check_and_get_column<ColumnString>(column.get());
const auto* col_in = assert_cast<const ColumnString*>(column.get());
DCHECK(col_in != nullptr);

size_t col_size = col_in->size();
Expand Down Expand Up @@ -1090,11 +1090,11 @@ class FunctionToIP : public IFunction {
if (addr_type.is_nullable()) {
const auto* addr_column_nullable =
assert_cast<const ColumnNullable*>(addr_column.get());
str_addr_column =
check_and_get_column<ColumnString>(addr_column_nullable->get_nested_column());
str_addr_column = assert_cast<const ColumnString*>(
addr_column_nullable->get_nested_column_ptr().get());
addr_null_map = &addr_column_nullable->get_null_map_data();
} else {
str_addr_column = check_and_get_column<ColumnString>(addr_column.get());
str_addr_column = assert_cast<const ColumnString*>(addr_column.get());
}

auto col_res = ColumnVector<Type>::create(input_rows_count, 0);
Expand Down

0 comments on commit 2052124

Please sign in to comment.