SecureRandom in JavaCryptoRandom is not seeded

apache · Jan 26, 2024 · 7a54fa3 · 7a54fa3
1 parent 55155fb
commit 7a54fa3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -94,6 +94,7 @@
       <action dev="ggregory"     type="fix" due-to="Gary Gregory">StreamInput.StreamInput(InputStream, int) now throws NullPointerException on null input.</action>
       <action dev="ggregory"     type="fix" due-to="Gary Gregory">ChannelOutput.ChannelOutput(WritableByteChannel) now throws NullPointerException on null input.</action>
       <action dev="ggregory"     type="fix" due-to="Gary Gregory">StreamOutput.StreamOutput(OutputStream, int) now throws NullPointerException on null input.</action>
+      <action dev="ggregory"     type="fix" due-to="Gary Gregory">SecureRandom in JavaCryptoRandom is not seeded.</action>
       <!-- UPDATE -->
       <action                    type="update" dev="sebb" due-to="Ludovic Henry">Dockerfile: Bump maven to 3.8.8 (previous no longer online)</action>
       <action                    type="update" dev="sebb">Tests: show details of crypt library actually loaded</action>

diff --git a/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java b/src/main/java/org/apache/commons/crypto/random/JavaCryptoRandom.java
@@ -47,6 +47,8 @@ public JavaCryptoRandom(final Properties properties) {
         } catch (final NoSuchAlgorithmException e) {
             tmp = new SecureRandom();
         }
+        // Seed the SecureRandom by calling nextBytes(byte[])
+        tmp.nextBytes(new byte[8]);
         instance = tmp;
     }