-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: enable project menu on mobile devices #9700
UI: enable project menu on mobile devices #9700
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9700 +/- ##
===========================================
Coverage 15.11% 15.11%
+ Complexity 11189 11187 -2
===========================================
Files 5406 5406
Lines 473215 473215
Branches 61384 59430 -1954
===========================================
+ Hits 71516 71528 +12
+ Misses 393891 393883 -8
+ Partials 7808 7804 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@weizhouapache have you tested this/ is it draft? I wonder why this was put in place. Is the reason for that gone? |
@DaanHoogland I used Chrome for testing
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
ok, will test on ff |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested in the simulator build!
Sorry mea culpa - I think it 'could' break on some screens; but LGTM. |
Description
This PR shows project menu on mobile devices
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?