CKS: add ConfigDrive to cloud-init datasource_list in systemvm template #7650

weizhouapache · 2023-06-19T12:13:37Z

Description

This PR fixes #7647

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2023-06-19T12:13:58Z

This requires a new systemvm template
cc @kiranchavala

codecov · 2023-06-19T13:10:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.81%. Comparing base (1d37ff2) to head (eb1b7b7).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #7650      +/-   ##
============================================
- Coverage     15.81%   15.81%   -0.01%     
+ Complexity    12554    12553       -1     
============================================
  Files          5629     5629              
  Lines        492031   492031              
  Branches      62921    63552     +631     
============================================
- Hits          77823    77813      -10     
- Misses       405888   405895       +7     
- Partials       8320     8323       +3

Flag	Coverage Δ
uitests	`4.48% <ø> (ø)`
unittests	`16.60% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weizhouapache · 2023-06-19T17:31:02Z

@blueorangutan package

blueorangutan · 2023-06-19T17:32:03Z

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-06-19T18:30:32Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6269

weizhouapache · 2023-06-19T19:30:53Z

@blueorangutan test

blueorangutan · 2023-06-19T19:32:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-06-20T11:55:17Z

[SF] Trillian test result (tid-6772)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57436 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t6772-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	82.72	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	52.45	test_vm_life_cycle.py

rohityadavcloud

LGTM didn't test the change, but have tested the URL fix - for the packer/systemvmtemplate build job (using my local jenkins instance)

blueorangutan · 2023-06-25T06:14:37Z

[SF] Trillian test result (tid-6837)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 41197 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t6837-kvm-rocky8.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2023-06-25T06:36:47Z

[SF] Trillian test result (tid-6839)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42825 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t6839-vmware-70u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2023-06-25T07:26:45Z

[SF] Trillian test result (tid-6838)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 45885 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t6838-kvm-ubuntu22.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2023-06-25T13:11:01Z

[SF] Trillian test result (tid-6840)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 66601 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t6840-xcpng82.zip
Smoke tests completed. 104 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_non_strict_host_anti_affinity	`Error`	197.66	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	130.22	test_nonstrict_affinity_group.py
test_deploy_vm_with_registered_userdata	`Error`	801.24	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	`Error`	819.10	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	`Error`	823.81	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	`Error`	820.90	test_register_userdata.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	595.31	test_internal_lb.py
test_list_volumes_metrics_history	`Failure`	188.35	test_metrics_api.py

DaanHoogland

code looks good

weizhouapache · 2023-06-26T08:35:19Z

thanks @rohityadavcloud @DaanHoogland for review

I have kicked some trillian test using the new templates. The kvm/vmware test results (see previous comments) look good.
There were some test failures with xcpng82. I have rekick the trillian test

blueorangutan · 2023-06-26T13:17:45Z

[SF] Trillian test result (tid-6841)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server r8
Total time taken: 70964 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t6841-xcpng82.zip
Smoke tests completed. 105 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_non_strict_host_anti_affinity	`Error`	198.92	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	110.32	test_nonstrict_affinity_group.py
test_deploy_vm_with_registered_userdata	`Error`	825.22	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	`Error`	862.03	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	`Error`	850.41	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	`Error`	839.74	test_register_userdata.py
test_list_volumes_metrics_history	`Failure`	284.39	test_metrics_api.py

blueorangutan · 2023-06-26T14:42:37Z

[SF] Trillian Build Failed (tid-6859)

blueorangutan · 2023-06-27T07:47:09Z

[SF] Trillian test result (tid-6861)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server 7
Total time taken: 62348 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t6861-vmware-80.zip
Smoke tests completed. 105 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_migration_options_storage_tags	`Error`	31.72	test_primary_storage.py
test_01_deploy_vm_on_specific_host	`Error`	21.67	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3601.65	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.24	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	2.24	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	2.24	test_vm_deployment_planner.py
test_01_offline_migrate_VM_and_root_volume	`Error`	122.79	test_vm_life_cycle.py
test_02_offline_migrate_VM_with_two_data_disks	`Error`	67.68	test_vm_life_cycle.py
test_03_live_migrate_VM_with_two_data_disks	`Error`	65.84	test_vm_life_cycle.py

blueorangutan · 2023-06-27T10:06:45Z

[SF] Trillian test result (tid-6858)
Environment: xcpng81 (x2), Advanced Networking with Mgmt server r8
Total time taken: 70965 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t6858-xcpng81.zip
Smoke tests completed. 104 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_non_strict_host_anti_affinity	`Error`	208.03	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	119.55	test_nonstrict_affinity_group.py
test_deploy_vm_with_registered_userdata	`Error`	822.24	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	`Error`	830.59	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	`Error`	835.42	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	`Error`	849.77	test_register_userdata.py
test_list_vms_metrics_admin	`Error`	0.23	test_metrics_api.py
test_list_vms_metrics_history	`Error`	0.22	test_metrics_api.py
test_list_volumes_metrics_history	`Error`	0.22	test_metrics_api.py
test_01_deploy_vm_on_specific_host	`Error`	0.11	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	0.09	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	0.13	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.14	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	0.10	test_vm_deployment_planner.py

blueorangutan · 2023-06-27T11:55:49Z

[SF] Trillian test result (tid-6860)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 77688 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t6860-vmware-67u3.zip
Smoke tests completed. 104 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_privategw_static_routes	`Failure`	621.51	test_privategw_acl.py
test_provision_certificate	`Error`	61.46	test_certauthority_root.py
test_01_create_template	`Error`	896.41	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.47	test_templates.py
test_03_delete_template	`Error`	824.08	test_templates.py
test_04_extract_template	`Error`	1.07	test_templates.py
test_deployvm_userdispersing	`Error`	1079.74	test_deploy_vms_with_varied_deploymentplanners.py

DaanHoogland · 2024-03-15T16:08:46Z

As I remember, it has been fixed in main branch. @DaanHoogland

ok, is main the right target for this?

weizhouapache · 2024-03-15T16:38:23Z

As I remember, it has been fixed in main branch. @DaanHoogland

ok, is main the right target for this?

yes @DaanHoogland
It requires a new systemvm template
The target branch is main, unless we will build 4.19.1 template. cc @sureshanaparti

JoaoJandre · 2024-07-29T17:55:40Z

@weizhouapache @DaanHoogland @rohityadavcloud are we missing something or can we merge this PR?

weizhouapache · 2024-07-29T18:52:18Z

@weizhouapache @DaanHoogland @rohityadavcloud are we missing something or can we merge this PR?

@JoaoJandre
it has label needs-testing

JoaoJandre · 2024-07-29T19:11:41Z

@weizhouapache @DaanHoogland @rohityadavcloud are we missing something or can we merge this PR?

@JoaoJandre it has label needs-testing

Oh, I didn't see it 😆

kiranchavala · 2024-09-17T11:20:20Z

@blueorangutan package

blueorangutan · 2024-09-17T11:22:03Z

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-17T11:36:33Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11131

weizhouapache · 2024-09-17T11:57:43Z

@blueorangutan package

blueorangutan · 2024-09-17T12:00:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-17T12:59:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11133

JoaoJandre

LGTM, did not test it

DaanHoogland · 2024-09-17T13:31:09Z

@weizhouapache when we merge this we will need a new systemvm template, or is the current good enough right now? cc @JoaoJandre, @kiranchavala .

weizhouapache · 2024-09-17T14:31:13Z

@weizhouapache when we merge this we will need a new systemvm template, or is the current good enough right now? cc @JoaoJandre, @kiranchavala .

@DaanHoogland we need a new template.

@kiranchavala is now testing the new systemvm template with new cksnode.sh

weizhouapache · 2024-09-17T14:34:00Z

@DaanHoogland
I have manually kicked 3 smoke tests (ol8, vmware-80u3, xcpng82) with new systemvm templates just now

blueorangutan · 2024-09-17T15:31:53Z

[SF] Trillian Build Failed (tid-11501)

blueorangutan · 2024-09-17T21:22:05Z

[SF] Trillian test result (tid-11502)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 22624 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t11502-xcpng82.zip
Smoke tests completed. 81 look OK, 22 have errors, 38 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	`Failure`	171.99	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Failure`	186.23	test_cluster_drs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	4.74	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Failure`	4.78	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	3.64	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	4.66	test_internal_lb.py
ContextSuite context=TestIpv4Routing>:setup	`Error`	0.00	test_ipv4_routing.py
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	2.54	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	2.32	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	2.29	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	2.29	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	2.28	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	2.27	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	2.30	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Error`	4.50	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	4.62	test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
ContextSuite context=TestListVolumes>:setup	`Error`	0.00	test_list_volumes.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
test_list_system_vms_metrics_history	`Failure`	0.33	test_metrics_api.py
test_list_vms_metrics_admin	`Error`	1.74	test_metrics_api.py
test_list_vms_metrics_history	`Error`	1.54	test_metrics_api.py
test_list_vms_metrics_user	`Error`	1.57	test_metrics_api.py
test_list_volumes_metrics_history	`Error`	1.38	test_metrics_api.py
test_nic_secondaryip_add_remove	`Error`	19.60	test_multipleips_per_nic.py
test_network_acl	`Error`	2.29	test_network_acl.py
test_01_verify_ipv6_network	`Error`	3.05	test_network_ipv6.py
test_01_verify_ipv6_network	`Error`	3.05	test_network_ipv6.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	2.57	test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	2.57	test_network_permissions.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	1.43	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.43	test_network_permissions.py
test_delete_account	`Error`	19.55	test_network.py
test_delete_network_while_vm_on_it	`Error`	2.38	test_network.py
test_delete_network_while_vm_on_it	`Error`	2.38	test_network.py
test_deploy_vm_l2network	`Error`	2.39	test_network.py
test_deploy_vm_l2network	`Error`	2.39	test_network.py
test_l2network_restart	`Error`	3.52	test_network.py
test_l2network_restart	`Error`	3.52	test_network.py
ContextSuite context=TestL2Networks>:teardown	`Error`	4.63	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	9.16	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	7.60	test_network.py
test_reboot_router	`Error`	4.26	test_network.py
test_releaseIP	`Error`	4.33	test_network.py
test_releaseIP_using_IP	`Error`	4.41	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	8.95	test_network.py
test_01_deployVMInSharedNetwork	`Failure`	1.23	test_network.py
test_02_verifyRouterIpAfterNetworkRestart	`Failure`	1.07	test_network.py
test_03_destroySharedNetwork	`Failure`	1.06	test_network.py
ContextSuite context=TestSharedNetwork>:teardown	`Error`	2.17	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	2.40	test_network.py
test_01_nic	`Error`	68.14	test_nic.py
test_01_non_strict_host_anti_affinity	`Error`	2.49	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	2.43	test_nonstrict_affinity_group.py
test_09_project_suspend	`Error`	2.39	test_projects.py
test_10_project_activation	`Error`	2.33	test_projects.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_isolated_persistent_network	`Error`	0.20	test_persistent_network.py
test_02_L2_persistent_network	`Error`	1.26	test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist	`Failure`	2.42	test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist	`Error`	2.42	test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown	`Error`	2.48	test_persistent_network.py
test_01_create_delete_portforwarding_fornonvpc	`Error`	4.70	test_portforwardingrules.py
test_01_add_primary_storage_disabled_host	`Error`	15.53	test_primary_storage.py
test_01_primary_storage_iscsi	`Error`	0.21	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.20	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.35	test_primary_storage.py
test_01_vpc_privategw_acl	`Failure`	5.17	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	5.44	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	5.47	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	5.34	test_privategw_acl.py
test_02_create_volume	`Error`	4.25	test_resource_names.py
all_test_router_dhcphosts	`Skipped`	---	test_router_dhcphosts.py
all_test_router_dns	`Skipped`	---	test_router_dns.py
all_test_router_dnsservice	`Skipped`	---	test_router_dnsservice.py
all_test_routers_iptables_default_policy	`Skipped`	---	test_routers_iptables_default_policy.py
all_test_routers_network_ops	`Skipped`	---	test_routers_network_ops.py
all_test_routers	`Skipped`	---	test_routers.py
all_test_safe_shutdown	`Skipped`	---	test_safe_shutdown.py
all_test_scale_vm	`Skipped`	---	test_scale_vm.py
all_test_secondary_storage	`Skipped`	---	test_secondary_storage.py
all_test_service_offerings	`Skipped`	---	test_service_offerings.py
all_test_set_sourcenat	`Skipped`	---	test_set_sourcenat.py
all_test_sharedfs_lifecycle	`Skipped`	---	test_sharedfs_lifecycle.py
all_test_snapshots	`Skipped`	---	test_snapshots.py
all_test_ssvm	`Skipped`	---	test_ssvm.py
all_test_staticroles	`Skipped`	---	test_staticroles.py
all_test_storage_policy	`Skipped`	---	test_storage_policy.py
all_test_templates	`Skipped`	---	test_templates.py
all_test_update_security_group	`Skipped`	---	test_update_security_group.py
all_test_usage_events	`Skipped`	---	test_usage_events.py
all_test_usage	`Skipped`	---	test_usage.py
all_test_vm_autoscaling	`Skipped`	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	`Skipped`	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	`Skipped`	---	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	`Skipped`	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_schedule	`Skipped`	---	test_vm_schedule.py
all_test_vm_snapshot_kvm	`Skipped`	---	test_vm_snapshot_kvm.py
all_test_vm_snapshots	`Skipped`	---	test_vm_snapshots.py
all_test_vm_strict_host_tags	`Skipped`	---	test_vm_strict_host_tags.py
all_test_vnf_templates	`Skipped`	---	test_vnf_templates.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

blueorangutan · 2024-09-18T05:42:08Z

[SF] Trillian test result (tid-11500)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52147 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t11500-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

kiranchavala

LGTM

Test manually on a kvm hypervisor

Able to launch a cks cluster successfully on a isolated network

Steps

Registered the new systemvm template
Create a new network offering with userdata as config drive
Created a isolated network with the network offering mentioned step 1
Launch a cks cluster

Performed lifecycle operations on the cks cluster like scaling, aquiring loadbalancer IP and destroying cks cluster

weizhouapache · 2024-09-18T07:20:39Z

LGTM

Test manually on a kvm hypervisor

Able to launch a cks cluster successfully on a isolated network

Steps

Registered the new systemvm template

Create a new network offering with userdata as config drive

Created a isolated network with the network offering mentioned step 1

Launch a cks cluster

Performed lifecycle operations on the cks cluster like scaling, aquiring loadbalancer IP and destroying cks cluster

thanks a lot @kiranchavala for the testing !

let's wait for smoke tests to be complete.

DaanHoogland · 2024-09-18T07:57:10Z

let's wait for smoke tests to be complete.

@weizhouapache , I see three smoke test feedback replies above.
#7650 (comment) (failed)
#7650 (comment) (lots of errors)
#7650 (comment) (flawless)

did you start any others?

blueorangutan · 2024-09-18T20:23:02Z

[SF] Trillian test result (tid-11504)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50881 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t11504-xcpng82.zip
Smoke tests completed. 102 look OK, 27 have errors, 12 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	`Failure`	213.87	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Failure`	178.21	test_cluster_drs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	3.74	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Failure`	3.71	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	3.67	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	2.62	test_internal_lb.py
ContextSuite context=TestIpv4Routing>:setup	`Error`	0.00	test_ipv4_routing.py
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	2.33	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	2.27	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	2.27	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	2.31	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	2.27	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	2.27	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	2.32	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Error`	3.49	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	3.59	test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
ContextSuite context=TestListVolumes>:setup	`Error`	0.00	test_list_volumes.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
test_list_system_vms_metrics_history	`Failure`	0.17	test_metrics_api.py
test_list_vms_metrics_admin	`Error`	1.74	test_metrics_api.py
test_list_vms_metrics_history	`Error`	1.56	test_metrics_api.py
test_list_vms_metrics_user	`Error`	1.66	test_metrics_api.py
test_list_volumes_metrics_history	`Error`	1.41	test_metrics_api.py
test_nic_secondaryip_add_remove	`Error`	19.82	test_multipleips_per_nic.py
test_network_acl	`Error`	2.30	test_network_acl.py
test_01_verify_ipv6_network	`Error`	2.98	test_network_ipv6.py
test_01_verify_ipv6_network	`Error`	2.98	test_network_ipv6.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	2.47	test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser	`Error`	2.47	test_network_permissions.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Failure`	1.38	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	`Error`	1.45	test_network_permissions.py
test_delete_account	`Error`	19.79	test_network.py
test_delete_network_while_vm_on_it	`Error`	2.38	test_network.py
test_delete_network_while_vm_on_it	`Error`	2.39	test_network.py
test_deploy_vm_l2network	`Error`	2.38	test_network.py
test_deploy_vm_l2network	`Error`	2.38	test_network.py
test_l2network_restart	`Error`	3.56	test_network.py
test_l2network_restart	`Error`	3.56	test_network.py
ContextSuite context=TestL2Networks>:teardown	`Error`	4.66	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	9.31	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	7.38	test_network.py
test_reboot_router	`Error`	4.65	test_network.py
test_releaseIP	`Error`	4.42	test_network.py
test_releaseIP_using_IP	`Error`	4.55	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	9.13	test_network.py
test_01_deployVMInSharedNetwork	`Failure`	1.25	test_network.py
test_02_verifyRouterIpAfterNetworkRestart	`Failure`	1.08	test_network.py
test_03_destroySharedNetwork	`Failure`	1.08	test_network.py
ContextSuite context=TestSharedNetwork>:teardown	`Error`	2.18	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	2.39	test_network.py
test_01_nic	`Error`	69.24	test_nic.py
test_01_non_strict_host_anti_affinity	`Error`	3.52	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	1.42	test_nonstrict_affinity_group.py
test_09_project_suspend	`Error`	2.45	test_projects.py
test_10_project_activation	`Error`	2.34	test_projects.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_isolated_persistent_network	`Error`	0.22	test_persistent_network.py
test_02_L2_persistent_network	`Error`	1.26	test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist	`Failure`	2.47	test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist	`Error`	2.47	test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown	`Error`	2.52	test_persistent_network.py
test_01_create_delete_portforwarding_fornonvpc	`Error`	4.67	test_portforwardingrules.py
test_01_add_primary_storage_disabled_host	`Error`	15.40	test_primary_storage.py
test_01_primary_storage_iscsi	`Error`	0.17	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.18	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.34	test_primary_storage.py
test_01_vpc_privategw_acl	`Failure`	5.44	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	5.16	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	5.72	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	5.30	test_privategw_acl.py
test_02_create_volume	`Error`	5.28	test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change	`Failure`	70.74	test_scale_vm.py
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.04	test_ssvm.py
ContextSuite context=TestCopyAndDeleteTemplatesAcrossZones>:teardown	`Error`	1462.23	test_templates.py
ContextSuite context=TestCreateTemplate>:setup	`Error`	1742.88	test_templates.py
test_02_1_create_template_with_checksum_sha1_negative	`Error`	63.06	test_templates.py
test_02_create_template_with_checksum_sha1	`Error`	48.29	test_templates.py
test_03_1_create_template_with_checksum_sha256_negative	`Error`	98.95	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	151.28	test_templates.py
test_04_1_create_template_with_checksum_md5_negative	`Error`	56.19	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	166.48	test_templates.py
test_05_create_template_with_no_checksum	`Error`	43.25	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	382.39	test_templates.py
test_01_deploy_vm_on_specific_host	`Error`	0.08	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.12	test_vm_deployment_planner.py
test_08_migrate_vm	`Error`	0.07	test_vm_life_cycle.py
all_test_vm_snapshots	`Skipped`	---	test_vm_snapshots.py
all_test_vm_strict_host_tags	`Skipped`	---	test_vm_strict_host_tags.py
all_test_vnf_templates	`Skipped`	---	test_vnf_templates.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

weizhouapache · 2024-09-18T20:37:40Z

let's wait for smoke tests to be complete.

@weizhouapache , I see three smoke test feedback replies above. #7650 (comment) (failed) #7650 (comment) (lots of errors) #7650 (comment) (flawless)

did you start any others?

@DaanHoogland
I have started test with vmware-70u3 and xenserver-74

the tests with xcpng82 and vmware-80u are unstable
refer to the test result of health check PR
#9316 (comment)
#9316 (comment)
#9316 (comment)

blueorangutan · 2024-09-18T22:36:42Z

[SF] Trillian test result (tid-11506)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58542 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t11506-vmware-70u3.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deployVMInSharedNetwork	`Error`	148.98	test_network.py
test_02_restore_vm_with_disk_offering	`Error`	62.32	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	`Error`	52.94	test_restore_vm.py

blueorangutan · 2024-09-18T23:00:34Z

[SF] Trillian Build Failed (tid-11517)

blueorangutan · 2024-09-19T22:08:42Z

[SF] Trillian test result (tid-11514)
Environment: xenserver-74 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 90222 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t11514-xenserver-74.zip
Smoke tests completed. 128 look OK, 11 have errors, 2 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	8.51	test_network.py
test_02_create_volume	`Error`	4.25	test_resource_names.py
test_01_scale_vm	`Error`	1.36	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	`Error`	1.28	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	`Error`	1.28	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	9.32	test_scale_vm.py
test_05_scale_vm_dont_allow_disk_offering_change	`Error`	1.34	test_scale_vm.py
test_01_sys_vm_start	`Failure`	0.09	test_secondary_storage.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	19.69	test_service_offerings.py
test_03_create_vpc_with_specified_source_nat_ip_address	`Error`	1.17	test_set_sourcenat.py
test_04_change_source_nat_ip_address_for_vpc	`Error`	1.18	test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
test_01_list_sec_storage_vm	`Failure`	0.03	test_ssvm.py
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_03_ssvm_internals	`Failure`	0.03	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.03	test_ssvm.py
test_05_stop_ssvm	`Failure`	0.03	test_ssvm.py
test_06_stop_cpvm	`Failure`	0.04	test_ssvm.py
test_07_reboot_ssvm	`Failure`	0.04	test_ssvm.py
test_08_reboot_cpvm	`Failure`	0.04	test_ssvm.py
test_09_reboot_ssvm_forced	`Failure`	0.04	test_ssvm.py
test_10_reboot_cpvm_forced	`Failure`	0.03	test_ssvm.py
test_11_destroy_ssvm	`Failure`	0.03	test_ssvm.py
test_12_destroy_cpvm	`Failure`	0.03	test_ssvm.py
ContextSuite context=TestVMWareStoragePolicies>:setup	`Error`	0.00	test_storage_policy.py
test_01_VPC_nics_after_destroy	`Error`	941.46	test_vpc_router_nics.py
test_02_VPC_default_routes	`Error`	810.00	test_vpc_router_nics.py
ContextSuite context=TestVPCNics>:teardown	`Error`	1238.02	test_vpc_router_nics.py
test_13_migrate_volume_and_change_offering	`Error`	7.46	test_volumes.py
all_test_templates	`Skipped`	---	test_templates.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py

CKS: add ConfigDrive to cloud-init datasource_list in systemvm template

b6863a5

boring-cyborg bot added component:templates component:systemvm-template labels Jun 19, 2023

weizhouapache added 2 commits June 19, 2023 15:15

systemvm template: update debian 11.7.0 iso url

7be3ffe

CKS: get K8S iso by LABEL=CDROM if config drive ISO is attached

726a0a7

boring-cyborg bot added the component:kubernetes label Jun 19, 2023

weizhouapache added this to the 4.18.1.0 milestone Jun 20, 2023

weizhouapache linked an issue Jun 20, 2023 that may be closed by this pull request

Unable to create a CKS cluster if the network offering contains userdata :ConfigDrive #7647

Open

rohityadavcloud approved these changes Jun 23, 2023

View reviewed changes

rohityadavcloud requested a review from DaanHoogland June 23, 2023 15:01

DaanHoogland approved these changes Jun 26, 2023

View reviewed changes

weizhouapache added the Severity:Major label Jun 26, 2023

weizhouapache mentioned this pull request Jul 17, 2024

Cloud-init not running when guest network use UsedData: ConfigDrive #9404

Open

rohityadavcloud requested a review from JoaoJandre September 17, 2024 10:14

rohityadavcloud assigned kiranchavala Sep 17, 2024

JoaoJandre approved these changes Sep 17, 2024

View reviewed changes

kiranchavala approved these changes Sep 18, 2024

View reviewed changes

Merge branch 'main' into 4.18-add-ConfigDrive-datasource

eb1b7b7

CKS: add ConfigDrive to cloud-init datasource_list in systemvm template #7650

Are you sure you want to change the base?

CKS: add ConfigDrive to cloud-init datasource_list in systemvm template #7650

Conversation

weizhouapache commented Jun 19, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache commented Jun 19, 2023

codecov bot commented Jun 19, 2023 • edited Loading

Codecov Report

weizhouapache commented Jun 19, 2023

blueorangutan commented Jun 19, 2023

blueorangutan commented Jun 19, 2023

weizhouapache commented Jun 19, 2023

blueorangutan commented Jun 19, 2023

blueorangutan commented Jun 20, 2023

rohityadavcloud left a comment

Choose a reason for hiding this comment

blueorangutan commented Jun 25, 2023

blueorangutan commented Jun 25, 2023

blueorangutan commented Jun 25, 2023

blueorangutan commented Jun 25, 2023

DaanHoogland left a comment

Choose a reason for hiding this comment

weizhouapache commented Jun 26, 2023

blueorangutan commented Jun 26, 2023

blueorangutan commented Jun 26, 2023

blueorangutan commented Jun 27, 2023

blueorangutan commented Jun 27, 2023

blueorangutan commented Jun 27, 2023

DaanHoogland commented Mar 15, 2024

weizhouapache commented Mar 15, 2024

JoaoJandre commented Jul 29, 2024

weizhouapache commented Jul 29, 2024

JoaoJandre commented Jul 29, 2024

kiranchavala commented Sep 17, 2024

blueorangutan commented Sep 17, 2024

blueorangutan commented Sep 17, 2024

weizhouapache commented Sep 17, 2024

blueorangutan commented Sep 17, 2024

blueorangutan commented Sep 17, 2024

JoaoJandre left a comment

Choose a reason for hiding this comment

DaanHoogland commented Sep 17, 2024

weizhouapache commented Sep 17, 2024

weizhouapache commented Sep 17, 2024

blueorangutan commented Sep 17, 2024

blueorangutan commented Sep 17, 2024

blueorangutan commented Sep 18, 2024

kiranchavala left a comment

Choose a reason for hiding this comment

weizhouapache commented Sep 18, 2024

DaanHoogland commented Sep 18, 2024

blueorangutan commented Sep 18, 2024

weizhouapache commented Sep 18, 2024

blueorangutan commented Sep 18, 2024

blueorangutan commented Sep 18, 2024

blueorangutan commented Sep 19, 2024

codecov bot commented Jun 19, 2023 •

edited

Loading