-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-6315] Support PostgreSQL TO_CHAR, TO_DATE, TO_TIMESTAMP #3753
Conversation
normanj-bitquill
commented
Apr 5, 2024
•
edited
Loading
edited
- Both functions use PostgreSQL format patterns
- Added tests for format patterns supported by PostgreSQL but missing from Calcite
- If the data or timestamp cannot be parsed using format string, then an exception is thrown.
The style checker has some complaints about your code. You can see them in the failed CI run. |
27ba99f
to
099c19c
Compare
@mihaibudiu Thank you, I have addressed the style checker error. The latest CI run failed when trying to pull the redis docker image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what happens to TO_CHAR in this PR.
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
099c19c
to
809e1a7
Compare
809e1a7
to
28d7713
Compare
@mihaibudiu Good point. I have updated the title of this PR and the commit message to say that I only added support for |
In order to keep track of JIRA/github, we require the JIRA title to be the same as the PR title, and the commit message. |
Quality Gate passedIssues Measures |
@mihaibudiu I don't have permission to change the title in Jira or to assign the ticket to myself. Can I get the necessary permissions? |
I edited the JIRA title. You shoud change the commit and PR titles. |
* Both functions use PostgreSQL format patterns * Added tests for format patterns supported by PostgreSQL but missing from Calcite * If the data or timestamp cannot be parsed using format string, then an exception is thrown.
28d7713
to
12a505e
Compare
@mihaibudiu Thanks for changing the title in Jira. I have updated the commit message and title of this PR. I'll sort out my Jira permissions. |