-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-2067] RexLiteral cannot represent accurately floating point values, including NaN, Infinity #3663
[CALCITE-2067] RexLiteral cannot represent accurately floating point values, including NaN, Infinity #3663
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -373,7 +373,7 @@ static void initializeArrowState(@TempDir Path sharedTempDir) | |
String sql = "select * from arrowdata\n" | ||
+ " where \"floatField\"=15.0"; | ||
String plan = "PLAN=ArrowToEnumerableConverter\n" | ||
+ " ArrowFilter(condition=[=(CAST($2):DOUBLE, 15.0)])\n" | ||
+ " ArrowFilter(condition=[=(CAST($2):DOUBLE, 15.0E0)])\n" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see a lot of Maybe I missed it, but somewhere in the javadoc (e.g. for RexLiteral) should state that goal. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I haven't changed how floating point values are serialized as text. The difference comes because now more literals contain a double/float. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense. +1 when you fix the issues in my other 2 comments |
||
+ " ArrowTableScan(table=[[ARROW, ARROWDATA]], fields=[[0, 1, 2, 3]])\n\n"; | ||
String result = "intField=15; stringField=15; floatField=15.0; longField=15\n"; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
float
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the same string that is used 3 lines above