[CALCITE-5409] Implement BatchNestedLoopJoin for JDBC #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kramerul
force-pushed
the
batch-nested-loop-jdbc
branch
2 times, most recently
from
1e605b9
to
480e4ba
Compare
kramerul
changed the title
kramerul
force-pushed
the
batch-nested-loop-jdbc
branch
2 times, most recently
from
3268a7c
to
3d0e301
Compare
kramerul
force-pushed
the
batch-nested-loop-jdbc
branch
from
3d0e301
to
b1f5867
Compare
|
Kudos, SonarCloud Quality Gate passed! |
tanclary
requested changes
Dec 24, 2023
| this.delegate = delegate; | ||
| this.parameters = parameters; | ||
| } | ||
| @Override public @Nullable SchemaPlus getRootSchema() { |
| if (context != null) { | ||
| return context; | ||
| } | ||
| List<RelDataTypeField> fieldList = variable.getType().getFieldList(); |
There was a problem hiding this comment.
Maybe I'm just not very familiar with JDBC but could we potentially add a comment or two explaining what is going on here. (If it's obvious to everyone but me then maybe not 🤷
| @@ -1147,6 +1153,52 @@ private LockWrapper exclusiveCleanDb(Connection c) throws SQLException { | |||
| }); | |||
| } | |||
|
|
|||
| @Test void testBatchNestedLoopJoinPlan() { | |||
There was a problem hiding this comment.
You could add comment with link to JIRA
| + "LEFT OUTER JOIN \"foodmart\".\"store\" B ON A.\"empid\" = B.\"store_id\""; | ||
| final String explain = "JdbcFilter(condition=[OR(=($cor0.empid0, $0), =($cor1.empid0, $0)"; | ||
| final String jdbcSql = "SELECT *\n" | ||
| + "FROM \"foodmart\".\"store\"\n" |
There was a problem hiding this comment.
Are there any other edge cases or situations we should test? Asked another way: Is one test enough to ensure that this works the way we intend?
There was a problem hiding this comment.
I think one test should be enough, as only one additional execution path is added to the code.
Context context = correlTableMap.get(variable.id);
if (context != null) {
return context;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CALCITE-5409