Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-6149] Unparse for CAST Nullable with ClickHouseSqlDialect #3556

Merged
merged 1 commit into from
Dec 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -79,25 +79,25 @@ public ClickHouseSqlDialect(Context context) {
SqlTypeName typeName = type.getSqlTypeName();
switch (typeName) {
case VARCHAR:
return createSqlDataTypeSpecByName("String", typeName);
return createSqlDataTypeSpecByName("String", typeName, type.isNullable());
case TINYINT:
return createSqlDataTypeSpecByName("Int8", typeName);
return createSqlDataTypeSpecByName("Int8", typeName, type.isNullable());
case SMALLINT:
return createSqlDataTypeSpecByName("Int16", typeName);
return createSqlDataTypeSpecByName("Int16", typeName, type.isNullable());
case INTEGER:
return createSqlDataTypeSpecByName("Int32", typeName);
return createSqlDataTypeSpecByName("Int32", typeName, type.isNullable());
case BIGINT:
return createSqlDataTypeSpecByName("Int64", typeName);
return createSqlDataTypeSpecByName("Int64", typeName, type.isNullable());
case REAL:
return createSqlDataTypeSpecByName("Float32", typeName);
return createSqlDataTypeSpecByName("Float32", typeName, type.isNullable());
case FLOAT:
case DOUBLE:
return createSqlDataTypeSpecByName("Float64", typeName);
return createSqlDataTypeSpecByName("Float64", typeName, type.isNullable());
case DATE:
return createSqlDataTypeSpecByName("Date", typeName);
return createSqlDataTypeSpecByName("Date", typeName, type.isNullable());
case TIMESTAMP:
case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
return createSqlDataTypeSpecByName("DateTime", typeName);
return createSqlDataTypeSpecByName("DateTime", typeName, type.isNullable());
default:
break;
}
Expand All @@ -107,11 +107,15 @@ public ClickHouseSqlDialect(Context context) {
}

private static SqlDataTypeSpec createSqlDataTypeSpecByName(String typeAlias,
SqlTypeName typeName) {
SqlTypeName typeName, boolean isNullable) {
if (isNullable) {
typeAlias = "Nullable(" + typeAlias + ")";
}
String finalTypeAlias = typeAlias;
SqlBasicTypeNameSpec spec = new SqlBasicTypeNameSpec(typeName, SqlParserPos.ZERO) {
@Override public void unparse(SqlWriter writer, int leftPrec, int rightPrec) {
// unparse as an identifier to ensure that type names are cased correctly
writer.identifier(typeAlias, true);
writer.identifier(finalTypeAlias, true);
}
};
return new SqlDataTypeSpec(spec, SqlParserPos.ZERO);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7120,6 +7120,21 @@ private void checkLiteral2(String expression, String expected) {
.withBigQuery().ok(expectedBiqquery);
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-6149">[CALCITE-6149]
* Unparse for CAST Nullable with ClickHouseSqlDialect</a>. */
@Test void testCastToNullableInClickhouse() {
final String query = ""
+ "SELECT CASE WHEN \"product_id\" IS NULL "
+ "THEN CAST(\"product_id\" AS TINYINT) END, CAST(\"product_id\" AS TINYINT)\n"
+ "FROM \"foodmart\".\"product\"";
final String expectedSql = ""
+ "SELECT CAST(NULL AS `Nullable(Int8)`), CAST(`product_id` AS `Int8`)\n"
+ "FROM `foodmart`.`product`";

sql(query).withClickHouse().ok(expectedSql);
}

@Test void testDialectQuoteStringLiteral() {
dialects().forEach((dialect, databaseProduct) -> {
assertThat(dialect.quoteStringLiteral(""), is("''"));
Expand Down
Loading