-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-6074] The size of REAL, DOUBLE, and FLOAT is not consistent #3492
Conversation
Does anyone want to review this PR? This PR clearly fixes multiple bugs caused by misunderstandings about the floating point types. |
@mihaibudiu PR looks good for me. I faced with the same problem when tried to convert sql from postgresql dialect to spark dialect. I was really surprise that spark float is 4 byte and postgres float is double precision by default. |
@@ -704,82 +686,6 @@ public static long getMaxValue(RelDataType type) { | |||
} | |||
} | |||
|
|||
/** Returns whether a type has a representation as a Java primitive (ignoring | |||
* nullability). */ | |||
@Deprecated // to be removed before 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I can't delete deprecated functions, so I will put these back.
0ab52e5
to
b719b3f
Compare
980cb3d
to
2f20c31
Compare
I am planning to merge this PR soon. If you have comments now is the time. |
Signed-off-by: Mihai Budiu <[email protected]>
2f20c31
to
29e2ec9
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 6 New issues |
This is based on a code audit.
The assumption is that FLOAT=DOUBLE=64 bit and REAL=32 bit
I also deleted some deprecated functions instead of fixing them.