[CALCITE-6021] Add CURRENT_DATETIME function (enabled in BigQuery library) #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanclary
force-pushed
the
6021-current-datetime
branch
from
613832c
to
a5f3926
Compare
tanclary
changed the title
tanclary
force-pushed
the
6021-current-datetime
branch
3 times, most recently
from
2f01971
to
99880b5
Compare
tjbanghart
reviewed
Oct 10, 2023
core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
Outdated
Show resolved
Hide resolved
julianhyde
reviewed
Oct 12, 2023
| | 2016-05-19T10:38:47.046465 | | ||
| +----------------------------+ | ||
| SELECT CURRENT_DATETIME > DATETIME '2008-12-25 15:30:00' as now; | ||
| +------+ |
There was a problem hiding this comment.
Would it be useful if Quidem had a way to mask out results? E.g.
!mask 6 "[0-9]" "x"
SELECT CURRENT_DATETIME as now;
+----------------------------+
| now |
+----------------------------+
| 2016-05-19T10:38:47.046465 |
+----------------------------+
would succeed because '2016-05-19T10:38:47.046465' and '2023-11-11T16:38:47.012345' would both be converted to 'xxxx-xx-xxTxx:xx:xx.xxxxxx'. The 6 means 'the next 6 lines'.
I logged julianhyde/quidem#79. Please add comments there.
There was a problem hiding this comment.
Left a comment on the issue, sounds like a good idea.
julianhyde
reviewed
Oct 12, 2023
| @@ -682,6 +682,9 @@ public enum BuiltInMethod { | |||
| CURRENT_TIMESTAMP(SqlFunctions.class, "currentTimestamp", DataContext.class), | |||
| CURRENT_TIME(SqlFunctions.class, "currentTime", DataContext.class), | |||
| CURRENT_DATE(SqlFunctions.class, "currentDate", DataContext.class), | |||
| CURRENT_DATETIME(SqlFunctions.class, "currentDatetime", DataContext.class), | |||
| CURRENT_DATETIME2(SqlFunctions.class, "currentDatetime", DataContext.class, | |||
| String.class), | |||
julianhyde
reviewed
Oct 12, 2023
| final String currentDateTimeExpr = "select ^current_datetime^"; | ||
| SqlValidatorFixture shouldFail = sql(currentDateTimeExpr) | ||
| .withConformance(SqlConformanceEnum.BIG_QUERY); | ||
| final String expectedError = "query [select CURRENT_DATETIME]; exception " | ||
| + "[Column 'CURRENT_DATETIME' not found in any table]; class " | ||
| + "[class org.apache.calcite.sql.validate.SqlValidatorException]; pos [line 1 col 8 thru line 1 col 8]"; | ||
| shouldFail.fails("Column 'CURRENT_DATETIME' not found in any table"); | ||
| // shouldFail.fails("Column 'CURRENT_DATETIME' not found in any table"); |
There was a problem hiding this comment.
remove the comment or the line
julianhyde
approved these changes
Oct 12, 2023
tanclary
force-pushed
the
6021-current-datetime
branch
4 times, most recently
from
9cea2e0
to
5aafb98
Compare
…rary) Co-authored-by: Julian Hyde <[email protected]> Co-authored-by: Tanner Clary <[email protected]>
tanclary
force-pushed
the
6021-current-datetime
branch
from
5aafb98
to
5a3d7ac
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.