[CALCITE-6015] AssertionError during optimization of EXTRACT expression #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
mihaibudiu
force-pushed
the
issue6015
branch
from
f7f8ab3
to
3674357
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
This PR implements several instances of the EXTRACT function which weren't supported. I would appreciate a review. |
|
Can anyone please review this PR? |
mihaibudiu
force-pushed
the
issue6015
branch
from
b385f8c
to
6090510
Compare
snuyanzin
reviewed
Mar 5, 2024
core/src/main/java/org/apache/calcite/sql/fun/SqlExtractFunction.java
Outdated
Show resolved
Hide resolved
rubenada
reviewed
Mar 8, 2024
rubenada
reviewed
Mar 9, 2024
|
Thanks @mihaibudiu , no further comment from my side. LGTM. |
|
Squashed the commits in preparation for merging. |
rubenada
reviewed
Mar 19, 2024
|
Thanks @mihaibudiu ! |
snuyanzin
approved these changes
Mar 21, 2024
mihaibudiu
commented
Mar 21, 2024
| f.checkFails("^extract(decade from time '12:34:56')^", fail, false); | ||
| f.checkFails("^extract(century from time '12:34:56')^", fail, false); | ||
| f.checkFails("^extract(century from time '12:34:56')^", fail, false); | ||
| f.checkFails("^extract(century from time '12:34:56')^", fail, false); |
There was a problem hiding this comment.
noticed some duplicated tests, I will delete these before merging.
Signed-off-by: Mihai Budiu <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to fix the bug described in the issue I have discovered that many cases for EXTRACT are actually not implemented. So I implemented most of them, and I have improved the validation as well; the case indicated in the JIRA issue will now be rejected statically.
There is one case for EXTRACT which I haven't implemented:
EXTRACT(EPOCH FROM INTERVAL '...' YEAR TO MONTH)because I wasn't sure how to properly use the convertlets to do it. Help would be appreciated.This PR also makes some unexpected tiny changes in SqlValidatorImpl and SqlCall, so I would appreciate comments from people who are more knowledgeable.