[CALCITE-5836] Implement Rel2Sql for MERGE #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Show resolved
Hide resolved
JiajunBernoulli
approved these changes
Sep 2, 2023
|
I made a rebase to solve problem of hundred of commits in this PR. |
|
Hi @JiajunBernoulli, Do you want to continue with the code review? If you think this PR is ok, do you consider merging it? |
| final SqlNode source = join.getLeft(); | ||
|
|
||
| SqlUpdate update = null; | ||
| List<String> updateColumnList = |
There was a problem hiding this comment.
Some variables can be final, please use final as much as possible.
There was a problem hiding this comment.
I have fixed this and squashed the commits.
Co-authored-by: Greg Hart <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
JiajunBernoulli
added
the
LGTM-will-merge-soon
|
Close #3310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support MERGE INTO cluase for JDBC adapter