[CALCITE-6150] Unparse for certain EXTRACT Unit with ClickHouseSqlDialect #11269

Execution failed for task ':core:autostyleJavaCheck'. > The following files have format violations: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java @@ -7457,10 +7457,14 @@ * <a href="https://issues.apache.org/jira/browse/CALCITE-6150">[CALCITE-6150] * Generate dialect-specific SQL for EXTRACT operator.</a>. */ @test void testExtract() { -····final·String·sql·=·"SELECT\n"·+␊ -········"EXTRACT(YEAR·FROM·DATE·'2023-12-01'),·EXTRACT(QUARTER·FROM·DATE·'2023-12-01'),·EXTRACT(MONTH·FROM·DATE·'2023-12-01'),\n"·+␊ -········"EXTRACT(WEEK·FROM·DATE·'2023-12-01'),·EXTRACT(DOY·FROM·DATE·'2023-12-01'),·EXTRACT(DAY·FROM·DATE·'2023-12-01'),\n"·+␊ -········"EXTRACT(DOW·FROM·DATE·'2023-12-01'),·EXTRACT(HOUR·FROM·TIMESTAMP·'2023-12-01·00:00:00'),\n"·+␊ +····final·String·sql·=·"SELECT\n"␊ +··+␊ +········"EXTRACT(YEAR·FROM·DATE·'2023-12-01'),·EXTRACT(QUARTER·FROM·DATE·'2023-12-01'),·EXTRACT(MONTH·FROM·DATE·'2023-12-01'),\n"␊ +··+␊ +········"EXTRACT(WEEK·FROM·DATE·'2023-12-01'),·EXTRACT(DOY·FROM·DATE·'2023-12-01'),·EXTRACT(DAY·FROM·DATE·'2023-12-01'),\n"␊ +··+␊ +········"EXTRACT(DOW·FROM·DATE·'2023-12-01'),·EXTRACT(HOUR·FROM·TIMESTAMP·'2023-12-01·00:00:00'),\n"␊ +··+␊ "EXTRACT(MINUTE FROM TIMESTAMP '2023-12-01 00:00:00'), EXTRACT(SECOND FROM TIMESTAMP '2023-12-01 00:00:00')"; final String expectedClickHouse = "SELECT " + "EXTRACT(YEAR FROM toDate('2023-12-01')), EXTRACT(QUARTER FROM toDate('2023-12-01')), EXTRACT(MONTH FROM toDate('2023-12-01')), " + @@ -7476,13 +7480,15 @@ "EXTRACT(YEAR FROM DATE '2023-12-01'), EXTRACT(QUARTER FROM DATE '2023-12-01'), EXTRACT(MONTH FROM DATE '2023-12-01'), " + "EXTRACT(WEEK FROM DATE '2023-12-01'), EXTRACT(DOY FROM DATE '2023-12-01'), EXTRACT(DAY FROM DATE '2023-12-01'), " + "EXTRACT(DOW FROM DATE '2023-12-01'), EXTRACT(HOUR FROM TIMESTAMP '2023-12-01 00:00:00'), " + -········"EXTRACT(MINUTE·FROM·TIMESTAMP·'2023-12-01·00:00:00'),·EXTRACT(SECOND·FROM·TIMESTAMP·'2023-12-01·00:00:00')\n"·+␊ +········"EXTRACT(MINUTE·FROM·TIMESTAMP·'2023-12-01·00:00:00'),·EXTRACT(SECOND·FROM·TIMESTAMP·'2023-12-01·00:00:00')\n"␊ +··+␊ "FROM (VALUES (0)) AS \"t\" (\"ZERO\")"; final String expectedHsqldb = "SELECT " + "EXTRACT(YEAR FROM DATE '2023-12-01'), EXTRACT(QUARTER FROM DATE '2023-12-01'), EXTRACT(MONTH FROM DATE '2023-12-01'), " + "EXTRACT(WEEK FROM DATE '2023-12-01'), EXTRACT(DOY FROM DATE '2023-12-01'), EXTRACT(DAY FROM DATE '2023-12-01'), " + "EXTRACT(DOW FROM DATE '2023-12-01'), EXTRACT(HOUR FROM TIMESTAMP '2023-12-01 00:00:00'), " + -········"EXTRACT(MINUTE·FROM·TIMESTAMP·'2023-12-01·00:00:00'),·EXTRACT(SECOND·FROM·TIMESTAMP·'2023-12-01·00:00:00')\n"·+␊ +········"EXTRACT(MINUTE·FROM·TIMESTAMP·'2023-12-01·00:00:00'),·EXTRACT(SECOND·FROM·TIMESTAMP·'2023-12-01·00:00:00')\n"␊ +··+␊ "FROM (VALUES (0)) AS t (ZERO)"; sql(sql) .withClickHouse().ok(expectedClickHouse) Run './gradlew autostyleApply' to fix the violations.

Linux (JDK 17): task ':core:autostyleJavaCheck'#L1

Execution failed for task ':core:autostyleJavaCheck': See 'What went wrong' below

Linux (JDK 17)

Linux (JDK 11), Pacific/Chatham Timezone: task ':core:autostyleJavaCheck'#L1

Execution failed for task ':core:autostyleJavaCheck': See 'What went wrong' below

Linux (JDK 11), Pacific/Chatham Timezone

Linux (JDK 8), oldest Guava, America/New_York Timezone: task ':core:autostyleJavaCheck'#L1

Execution failed for task ':core:autostyleJavaCheck': See 'What went wrong' below

Linux (JDK 8), oldest Guava, America/New_York Timezone

Linux (JDK 11), Avatica main: task ':core:autostyleJavaCheck'#L1

Execution failed for task ':core:autostyleJavaCheck': See 'What went wrong' below

Linux (JDK 11), Avatica main

Linux (JDK 8), latest Guava, America/New_York Timezone: task ':core:autostyleJavaCheck'#L1

Execution failed for task ':core:autostyleJavaCheck': See 'What went wrong' below

Linux (JDK 8), latest Guava, America/New_York Timezone

Windows (JDK 17): task ':core:autostyleJavaCheck'#L1

Execution failed for task ':core:autostyleJavaCheck': See 'What went wrong' below

Windows (JDK 17)

Execution failed for task ':core:autostyleJavaCheck'. > The following files have format violations: core\src\test\java\org\apache\calcite\rel\rel2sql\RelToSqlConverterTest.java @@ -7457,10 +7457,14 @@ * <a href="https://issues.apache.org/jira/browse/CALCITE-6150">[CALCITE-6150] * Generate dialect-specific SQL for EXTRACT operator.</a>. */ @test void testExtract() { - final String sql = "SELECT\n" +\r\n - "EXTRACT(YEAR FROM DATE '2023-12-01'), EXTRACT(QUARTER FROM DATE '2023-12-01'), EXTRACT(MONTH FROM DATE '2023-12-01'),\n" +\r\n - "EXTRACT(WEEK FROM DATE '2023-12-01'), EXTRACT(DOY FROM DATE '2023-12-01'), EXTRACT(DAY FROM DATE '2023-12-01'),\n" +\r\n - "EXTRACT(DOW FROM DATE '2023-12-01'), EXTRACT(HOUR FROM TIMESTAMP '2023-12-01 00:00:00'),\n" +\r\n + final String sql = "SELECT\n"\r\n + +\r\n + "EXTRACT(YEAR FROM DATE '2023-12-01'), EXTRACT(QUARTER FROM DATE '2023-12-01'), EXTRACT(MONTH FROM DATE '2023-12-01'),\n"\r\n + +\r\n + "EXTRACT(WEEK FROM DATE '2023-12-01'), EXTRACT(DOY FROM DATE '2023-12-01'), EXTRACT(DAY FROM DATE '2023-12-01'),\n"\r\n + +\r\n + "EXTRACT(DOW FROM DATE '2023-12-01'), EXTRACT(HOUR FROM TIMESTAMP '2023-12-01 00:00:00'),\n"\r\n + +\r\n "EXTRACT(MINUTE FROM TIMESTAMP '2023-12-01 00:00:00'), EXTRACT(SECOND FROM TIMESTAMP '2023-12-01 00:00:00')"; final String expectedClickHouse = "SELECT " + "EXTRACT(YEAR FROM toDate('2023-12-01')), EXTRACT(QUARTER FROM toDate('2023-12-01')), EXTRACT(MONTH FROM toDate('2023-12-01')), " + @@ -7476,13 +7480,15 @@ "EXTRACT(YEAR FROM DATE '2023-12-01'), EXTRACT(QUARTER FROM DATE '2023-12-01'), EXTRACT(MONTH FROM DATE '2023-12-01'), " + "EXTRACT(WEEK FROM DATE '2023-12-01'), EXTRACT(DOY FROM DATE '2023-12-01'), EXTRACT(DAY FROM DATE '2023-12-01'), " + "EXTRACT(DOW FROM DATE '2023-12-01'), EXTRACT(HOUR FROM TIMESTAMP '2023-12-01 00:00:00'), " + - "EXTRACT(MINUTE FROM TIMESTAMP '2023-12-01 00:00:00'), EXTRACT(SECOND FROM TIMESTAMP '2023-12-01 00:00:00')\n" +\r\n + "EXTRACT(MINUTE FROM TIMESTAMP '2023-12-01 00:00:00'), EXTRACT(SECOND FROM TIMESTAMP '2023-12-01 00:00:00')\n"\r\n + +\r\n "FROM (VALUES (0)) AS \"t\" (\"ZERO\")"; final String expectedHsqldb = "SELECT " + "EXTRACT(YEAR FROM DATE '2023-12-01'), EXTRACT(QUARTER FROM DATE '2023-12-01'), EXTRACT(MONTH FROM DATE '2023-12-01'), " + "EXTRACT(WEEK FROM DATE '2023-12-01'), EXTRACT(DOY FROM DATE '2023-12-01'), EXTRACT(DAY FROM DATE '2023-12-01'), " + "EXTRACT(DOW FROM DATE '2023-12-01'), EXTRACT(HOUR FROM TIMESTAMP '2023-12-01 00:00:00'), " + - "EXTRACT(MINUTE FROM TIMESTAMP '2023-12-01 00:00:00'), EXTRACT(SECOND FROM TIMESTAMP '2023-12-01 00:00:00')\n" +\r\n + "EXTRACT(MINUTE FROM TIMESTAMP '2023-12-01 00:00:00'), EXTRACT(SECOND FROM TIMESTAMP '2023-12-01 00:00:00')\n"\r\n + +\r\n "FROM (VALUES (0)) AS t (ZERO)"; sql(sql) .withClickHouse().ok(expectedClickHouse) Run './gradlew autostyleApply' to fix the violations.

Windows (JDK 8): task ':core:autostyleJavaCheck'#L1

Execution failed for task ':core:autostyleJavaCheck': See 'What went wrong' below

Windows (JDK 8)

Druid Tests: DruidAdapter2IT.java#L2025

0.3sec org.apache.calcite.test.DruidAdapter2IT > testInterleaveBetweenAggregateAndGroupOrderByOnMetrics() java.lang.AssertionError: Expected: "store_state=CA; brand_name=King; A=21.4632\nstore_state=OR; brand_name=Symphony; A=32.176\nstore_state=CA; brand_name=Toretti; A=32.2465\nstore_state=WA; brand_name=King; A=34.6104\nstore_state=OR; brand_name=Toretti; A=36.3" but: was "store_state=OR; brand_name=ADJ; A=83.8764\nstore_state=WA; brand_name=Akron; A=85.8402\nstore_state=OR; brand_name=American; A=86.7898\nstore_state=WA; brand_name=ADJ; A=97.6488\nstore_state=CA; brand_name=ADJ; A=98.0076" at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6) at org.apache.calcite.test.CalciteAssert.lambda$checkResult$6(CalciteAssert.java:453) at org.apache.calcite.test.CalciteAssert.assertQuery(CalciteAssert.java:582) at org.apache.calcite.test.CalciteAssert$AssertQuery.lambda$returns$1(CalciteAssert.java:1495) at org.apache.calcite.test.CalciteAssert$AssertQuery.withConnection(CalciteAssert.java:1434) at org.apache.calcite.test.CalciteAssert$AssertQuery.returns(CalciteAssert.java:1493) at org.apache.calcite.test.CalciteAssert$AssertQuery.returns(CalciteAssert.java:1483) at org.apache.calcite.test.CalciteAssert$AssertQuery.returnsOrdered(CalciteAssert.java:1509) at org.apache.calcite.test.DruidAdapter2IT.testInterleaveBetweenAggregateAndGroupOrderByOnMetrics(DruidAdapter2IT.java:2025) Suppressed: org.apache.calcite.util.TestUtil$ExtraInformation: With materializationsEnabled=false, limit=-1, sql=select "store_state", "brand_name", "A" from ( select sum("store_sales")-sum("store_cost") as a, "store_state", "brand_name" from "foodmart" group by "store_state", "brand_name" ) subq order by "A" limit 5 at app//org.apache.calcite.util.TestUtil.rethrow(TestUtil.java:389) at app//org.apache.calcite.test.CalciteAssert.assertQuery(CalciteAssert.java:598) ... 6 more

Druid Tests: DruidAdapterIT.java#L2336

0.8sec org.apache.calcite.test.DruidAdapterIT > testInterleaveBetweenAggregateAndGroupOrderByOnMetrics() java.lang.AssertionError: Expected: "store_state=CA; brand_name=King; A=21.4632\nstore_state=OR; brand_name=Symphony; A=32.176\nstore_state=CA; brand_name=Toretti; A=32.2465\nstore_state=WA; brand_name=King; A=34.6104\nstore_state=OR; brand_name=Toretti; A=36.3" but: was "store_state=OR; brand_name=ADJ; A=83.8764\nstore_state=WA; brand_name=Akron; A=85.8402\nstore_state=OR; brand_name=American; A=86.7898\nstore_state=WA; brand_name=ADJ; A=97.6488\nstore_state=CA; brand_name=ADJ; A=98.0076" at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6) at org.apache.calcite.test.CalciteAssert.lambda$checkResult$6(CalciteAssert.java:453) at org.apache.calcite.test.CalciteAssert.assertQuery(CalciteAssert.java:582) at org.apache.calcite.test.CalciteAssert$AssertQuery.lambda$returns$1(CalciteAssert.java:1495) at org.apache.calcite.test.CalciteAssert$AssertQuery.withConnection(CalciteAssert.java:1434) at org.apache.calcite.test.CalciteAssert$AssertQuery.returns(CalciteAssert.java:1493) at org.apache.calcite.test.CalciteAssert$AssertQuery.returns(CalciteAssert.java:1483) at org.apache.calcite.test.CalciteAssert$AssertQuery.returnsOrdered(CalciteAssert.java:1509) at org.apache.calcite.test.DruidAdapterIT.testInterleaveBetweenAggregateAndGroupOrderByOnMetrics(DruidAdapterIT.java:2336) Suppressed: org.apache.calcite.util.TestUtil$ExtraInformation: With materializationsEnabled=false, limit=-1, sql=select "store_state", "brand_name", "A" from ( select sum("store_sales")-sum("store_cost") as a, "store_state", "brand_name" from "foodmart" group by "store_state", "brand_name" ) subq order by "A" limit 5 at app//org.apache.calcite.util.TestUtil.rethrow(TestUtil.java:389) at app//org.apache.calcite.test.CalciteAssert.assertQuery(CalciteAssert.java:598) ... 6 more

Druid Tests: task ':druid:test'#L1

Execution failed for task ':druid:test': org.gradle.api.tasks.VerificationException: There were failing tests. See the report at: file:///home/runner/work/calcite/calcite/calcite/druid/build/reports/tests/test/index.html

Druid Tests

Execution failed for task ':druid:test'. > There were failing tests. See the report at: file:///home/runner/work/calcite/calcite/calcite/druid/build/reports/tests/test/index.html

macOS (JDK 19): task ':core:autostyleJavaCheck'#L1

Execution failed for task ':core:autostyleJavaCheck': See 'What went wrong' below

macOS (JDK 19)