-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable Managed BigQuery destinations #33017
Portable Managed BigQuery destinations #33017
Conversation
…hods can instead be done in Dataflow service side
Depends on #31486 getting in |
…t transform is chosen
…change tests to verify underlying transform name
…into managed_bq_portable_dest
…ged_bq_portable_dest
R: @chamikaramj this is ready for a review! |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
...rc/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/PortableBigQueryDestinations.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/PortableBigQueryDestinations.java
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/PortableBigQueryDestinations.java
Outdated
Show resolved
Hide resolved
Failing test is unrelated -- merging now |
Add portable dynamic destinations* to the BigQuery write schematransforms. This can be used in both cross-language and Managed BigQuery writes.