SolaceIO: separate auth and session settings #32406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…31905. This PR adds the actual writer functionality, and some additional testing, including integration testing. This should be final PR for the SolaceIO write connector to be complete.
… inheritance and overriding of SessionService
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
@bzablocki @Abacn what are next steps on this PR? |
|
It's blocked by #32400, waiting for that to be merged. I'll be monitoring it and ping you once it is ready for a review. |
sjvanrossum
reviewed
Nov 13, 2024
Comment on lines
130
to
132
| Queue queueNotNull = checkStateNotNull(queue(), "SolaceIO.Read: Queue is not set."); | ||
|
|
||
| Queue queue = | ||
| JCSMPFactory.onlyInstance() | ||
| .createQueue(checkStateNotNull(queueName(), "SolaceIO.Read: Queue is not set.")); | ||
| Queue queue = JCSMPFactory.onlyInstance().createQueue(queueNotNull.getName()); |
There was a problem hiding this comment.
This doesn't seem quite right, you already have a Queue instance at this point, what's the point of having the factory recreate it?
There was a problem hiding this comment.
You're right, this queue is already initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored to separate authentication and session settings, and allow inheritance and overriding of SessionService.
Depends on #32400, waiting for that to be merged
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.