-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yaml] Add use cases for Enrichment transform in YAML #32289
Open
reeba212
wants to merge
7
commits into
apache:master
Choose a base branch
from
reeba212:spanner-enrichment-use-case
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d2ab5c8
Create use case for enriching spanner data with bigquery
reeba212 5c7ee2e
Create example for bigtable enrichment
reeba212 a4bc69a
Add project_id parameter to BigQueryWrapper
reeba212 eabafaf
minor changes
reeba212 844d9de
remove project id being passed into bigquery wrapper
reeba212 46a0e95
add license
reeba212 f5d0aa3
add expected blocks
reeba212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
sdks/python/apache_beam/yaml/examples/bigtable_enrichment.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# coding=utf-8 | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
pipeline: | ||
type: chain | ||
transforms: | ||
|
||
# Step 1: Creating a collection of elements that needs | ||
# to be enriched. Here we are simulating sales data | ||
- type: Create | ||
config: | ||
elements: | ||
- sale_id: 1 | ||
customer_id: 1 | ||
product_id: 1 | ||
quantity: 1 | ||
|
||
# Step 2: Enriching the data with Bigtable | ||
# This specific bigtable stores product data in the below format | ||
# product:product_id, product:product_name, product:product_stock | ||
- type: Enrichment | ||
config: | ||
enrichment_handler: 'BigTable' | ||
handler_config: | ||
project_id: 'apache-beam-testing' | ||
instance_id: 'beam-test' | ||
table_id: 'bigtable-enrichment-test' | ||
row_key: 'product_id' | ||
timeout: 30 | ||
|
||
# Step 3: Logging for testing | ||
# This is a simple way to view the enriched data | ||
# We can also store it somewhere like a json file | ||
- type: LogForTesting | ||
|
||
# Expected: | ||
# Row(sale_id = 1, customer_id = 1, product_id = 1, quantity = 1, product = Row(product_id: "1", product_name = "pixel 5", product_stock = "2")) | ||
96 changes: 96 additions & 0 deletions
96
sdks/python/apache_beam/yaml/examples/enrich_spanner_with_bigquery.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,96 @@ | ||||||||||
# coding=utf-8 | ||||||||||
# | ||||||||||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||||||||||
# contributor license agreements. See the NOTICE file distributed with | ||||||||||
# this work for additional information regarding copyright ownership. | ||||||||||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||||||||||
# (the "License"); you may not use this file except in compliance with | ||||||||||
# the License. You may obtain a copy of the License at | ||||||||||
# | ||||||||||
# http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||
# | ||||||||||
# Unless required by applicable law or agreed to in writing, software | ||||||||||
# distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||
# See the License for the specific language governing permissions and | ||||||||||
# limitations under the License. | ||||||||||
# | ||||||||||
|
||||||||||
pipeline: | ||||||||||
transforms: | ||||||||||
# Step 1: Read orders details from Spanner | ||||||||||
- type: ReadFromSpanner | ||||||||||
name: ReadOrders | ||||||||||
config: | ||||||||||
project_id: 'apache-beam-testing' | ||||||||||
instance_id: 'orders-test' | ||||||||||
database_id: 'order-database' | ||||||||||
query: 'SELECT customer_id, product_id, order_date, order_amount FROM orders' | ||||||||||
|
||||||||||
# Step 2: Enrich order details with customers details from BigQuery | ||||||||||
- type: Enrichment | ||||||||||
name: Enriched | ||||||||||
input: ReadOrders | ||||||||||
config: | ||||||||||
enrichment_handler: 'BigQuery' | ||||||||||
handler_config: | ||||||||||
project: "apache-beam-testing" | ||||||||||
table_name: "apache-beam-testing.ALL_TEST.customers" | ||||||||||
row_restriction_template: "customer_id = 1001 or customer_id = 1003" | ||||||||||
fields: ["customer_id"] | ||||||||||
|
||||||||||
# Step 3: Map enriched values to Beam schema | ||||||||||
# TODO: This should be removed when schema'd enrichment is available | ||||||||||
- type: MapToFields | ||||||||||
name: MapEnrichedValues | ||||||||||
input: Enriched | ||||||||||
config: | ||||||||||
language: python | ||||||||||
fields: | ||||||||||
customer_id: | ||||||||||
callable: 'lambda x: x.customer_id' | ||||||||||
output_type: integer | ||||||||||
customer_name: | ||||||||||
callable: 'lambda x: x.customer_name' | ||||||||||
output_type: string | ||||||||||
customer_email: | ||||||||||
callable: 'lambda x: x.customer_email' | ||||||||||
output_type: string | ||||||||||
product_id: | ||||||||||
callable: 'lambda x: x.product_id' | ||||||||||
output_type: integer | ||||||||||
order_date: | ||||||||||
callable: 'lambda x: x.order_date' | ||||||||||
output_type: string | ||||||||||
order_amount: | ||||||||||
callable: 'lambda x: x.order_amount' | ||||||||||
output_type: integer | ||||||||||
|
||||||||||
# Step 4: Filter orders with amount greater than 100 | ||||||||||
- type: Filter | ||||||||||
name: FilterHighValueOrders | ||||||||||
input: MapEnrichedValues | ||||||||||
config: | ||||||||||
keep: "order_amount > 100" | ||||||||||
language: "python" | ||||||||||
|
||||||||||
|
||||||||||
# Step 6: Write processed order to another spanner table | ||||||||||
- type: WriteToSpanner | ||||||||||
name: WriteProcessedOrders | ||||||||||
input: FilterHighValueOrders | ||||||||||
config: | ||||||||||
project_id: 'apache-beam-testing' | ||||||||||
instance_id: 'orders-test' | ||||||||||
database_id: 'order-database' | ||||||||||
table_id: 'orders_with_customers' | ||||||||||
error_handling: | ||||||||||
output: my_error_output | ||||||||||
|
||||||||||
# Step 7: Handle write errors by writing to JSON | ||||||||||
- type: WriteToJson | ||||||||||
name: WriteErrorsToJson | ||||||||||
input: WriteProcessedOrders.my_error_output | ||||||||||
config: | ||||||||||
path: 'errors.json' | ||||||||||
|
||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add Expected block:
Suggested change
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -156,7 +156,7 @@ def _wordcount_test_preprocessor( | |
|
||
|
||
@YamlExamplesTestSuite.register_test_preprocessor( | ||
['test_simple_filter_yaml', 'test_simple_filter_and_combine_yaml']) | ||
['test_simple_filter_yaml', 'test_simple_filter_and_combine_yaml', 'test_spanner_read_yaml', 'test_spanner_write_yaml']) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Should look very similar to the change on line 159 above |
||
def _file_io_write_test_preprocessor( | ||
test_spec: dict, expected: List[str], env: TestEnvironment): | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.