-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Validate commits in StreamingDataflowWorker (#31822)
* Grabs operational limits from streaming config and plumbs them to WindmillSink, which can then throw an exception or log a warning if outputs are too large.
- Loading branch information
Showing
12 changed files
with
311 additions
and
37 deletions.
There are no files selected for viewing
64 changes: 64 additions & 0 deletions
64
...-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/OperationalLimits.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.runners.dataflow.worker; | ||
|
|
||
| import com.google.auto.value.AutoBuilder; | ||
|
|
||
| /** Keep track of any operational limits required by the backend. */ | ||
| public class OperationalLimits { | ||
| // Maximum size of a commit from a single work item. | ||
| public final long maxWorkItemCommitBytes; | ||
| // Maximum size of a single output element's serialized key. | ||
| public final long maxOutputKeyBytes; | ||
| // Maximum size of a single output element's serialized value. | ||
| public final long maxOutputValueBytes; | ||
| // Whether to throw an exception when processing output that violates any of the given limits. | ||
| public final boolean throwExceptionOnLargeOutput; | ||
|
|
||
| OperationalLimits( | ||
| long maxWorkItemCommitBytes, | ||
| long maxOutputKeyBytes, | ||
| long maxOutputValueBytes, | ||
| boolean throwExceptionOnLargeOutput) { | ||
| this.maxWorkItemCommitBytes = maxWorkItemCommitBytes; | ||
| this.maxOutputKeyBytes = maxOutputKeyBytes; | ||
| this.maxOutputValueBytes = maxOutputValueBytes; | ||
| this.throwExceptionOnLargeOutput = throwExceptionOnLargeOutput; | ||
| } | ||
|
|
||
| @AutoBuilder(ofClass = OperationalLimits.class) | ||
| public interface Builder { | ||
| Builder setMaxWorkItemCommitBytes(long bytes); | ||
|
|
||
| Builder setMaxOutputKeyBytes(long bytes); | ||
|
|
||
| Builder setMaxOutputValueBytes(long bytes); | ||
|
|
||
| Builder setThrowExceptionOnLargeOutput(boolean shouldThrow); | ||
|
|
||
| OperationalLimits build(); | ||
| } | ||
|
|
||
| public static Builder builder() { | ||
| return new AutoBuilder_OperationalLimits_Builder() | ||
| .setMaxWorkItemCommitBytes(Long.MAX_VALUE) | ||
| .setMaxOutputKeyBytes(Long.MAX_VALUE) | ||
| .setMaxOutputValueBytes(Long.MAX_VALUE) | ||
| .setThrowExceptionOnLargeOutput(false); | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
...worker/src/main/java/org/apache/beam/runners/dataflow/worker/OutputTooLargeException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.runners.dataflow.worker; | ||
|
|
||
| import org.checkerframework.checker.nullness.qual.Nullable; | ||
|
|
||
| /** Indicates that an output element was too large. */ | ||
| public class OutputTooLargeException extends RuntimeException { | ||
| public OutputTooLargeException(String reason) { | ||
| super(reason); | ||
| } | ||
|
|
||
| /** Returns whether an exception was caused by a {@link OutputTooLargeException}. */ | ||
| public static boolean isCausedByOutputTooLargeException(@Nullable Throwable t) { | ||
| while (t != null) { | ||
| if (t instanceof OutputTooLargeException) { | ||
| return true; | ||
| } | ||
| t = t.getCause(); | ||
| } | ||
| return false; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.