-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix silent failures in dispatch loop from stalling the pipeline (#32922)
* use ExecutorService instead of ScheduledExecutorService which swallows exceptions into futures that were not examined Co-authored-by: Arun Pandian <[email protected]>
- Loading branch information
1 parent
8b1ca21
commit 88ada9d
Showing
10 changed files
with
136 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
.../apache/beam/runners/dataflow/worker/streaming/harness/SingleSourceWorkerHarnessTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.runners.dataflow.worker.streaming.harness; | ||
|
|
||
| import static com.google.common.truth.Truth.assertThat; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.mockito.Mockito.mock; | ||
|
|
||
| import java.util.Optional; | ||
| import java.util.concurrent.CountDownLatch; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.function.Function; | ||
| import org.apache.beam.runners.dataflow.worker.WorkerUncaughtExceptionHandler; | ||
| import org.apache.beam.runners.dataflow.worker.streaming.ComputationState; | ||
| import org.apache.beam.runners.dataflow.worker.util.common.worker.JvmRuntime; | ||
| import org.apache.beam.runners.dataflow.worker.windmill.client.commits.WorkCommitter; | ||
| import org.apache.beam.runners.dataflow.worker.windmill.client.getdata.GetDataClient; | ||
| import org.apache.beam.runners.dataflow.worker.windmill.work.processing.StreamingWorkScheduler; | ||
| import org.apache.beam.runners.dataflow.worker.windmill.work.refresh.HeartbeatSender; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| @RunWith(JUnit4.class) | ||
| public class SingleSourceWorkerHarnessTest { | ||
| private static final Logger LOG = LoggerFactory.getLogger(SingleSourceWorkerHarnessTest.class); | ||
| private final WorkCommitter workCommitter = mock(WorkCommitter.class); | ||
| private final GetDataClient getDataClient = mock(GetDataClient.class); | ||
| private final HeartbeatSender heartbeatSender = mock(HeartbeatSender.class); | ||
| private final Runnable waitForResources = () -> {}; | ||
| private final Function<String, Optional<ComputationState>> computationStateFetcher = | ||
| ignored -> Optional.empty(); | ||
| private final StreamingWorkScheduler streamingWorkScheduler = mock(StreamingWorkScheduler.class); | ||
|
|
||
| private SingleSourceWorkerHarness createWorkerHarness( | ||
| SingleSourceWorkerHarness.GetWorkSender getWorkSender, JvmRuntime runtime) { | ||
| // In non-test scenario this is set in DataflowWorkerHarnessHelper.initializeLogging(...). | ||
| Thread.setDefaultUncaughtExceptionHandler(new WorkerUncaughtExceptionHandler(runtime, LOG)); | ||
| return SingleSourceWorkerHarness.builder() | ||
| .setWorkCommitter(workCommitter) | ||
| .setGetDataClient(getDataClient) | ||
| .setHeartbeatSender(heartbeatSender) | ||
| .setWaitForResources(waitForResources) | ||
| .setStreamingWorkScheduler(streamingWorkScheduler) | ||
| .setComputationStateFetcher(computationStateFetcher) | ||
| .setGetWorkSender(getWorkSender) | ||
| .build(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDispatchLoop_unexpectedFailureKillsJvm_appliance() { | ||
| SingleSourceWorkerHarness.GetWorkSender getWorkSender = | ||
| SingleSourceWorkerHarness.GetWorkSender.forAppliance( | ||
| () -> { | ||
| throw new RuntimeException("something bad happened"); | ||
| }); | ||
|
|
||
| FakeJvmRuntime fakeJvmRuntime = new FakeJvmRuntime(); | ||
| createWorkerHarness(getWorkSender, fakeJvmRuntime).start(); | ||
| assertTrue(fakeJvmRuntime.waitForRuntimeDeath(5, TimeUnit.SECONDS)); | ||
| fakeJvmRuntime.assertJvmTerminated(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDispatchLoop_unexpectedFailureKillsJvm_streamingEngine() { | ||
| SingleSourceWorkerHarness.GetWorkSender getWorkSender = | ||
| SingleSourceWorkerHarness.GetWorkSender.forStreamingEngine( | ||
| workItemReceiver -> { | ||
| throw new RuntimeException("something bad happened"); | ||
| }); | ||
|
|
||
| FakeJvmRuntime fakeJvmRuntime = new FakeJvmRuntime(); | ||
| createWorkerHarness(getWorkSender, fakeJvmRuntime).start(); | ||
| assertTrue(fakeJvmRuntime.waitForRuntimeDeath(5, TimeUnit.SECONDS)); | ||
| fakeJvmRuntime.assertJvmTerminated(); | ||
| } | ||
|
|
||
| private static class FakeJvmRuntime implements JvmRuntime { | ||
| private final CountDownLatch haltedLatch = new CountDownLatch(1); | ||
| private volatile int exitStatus = 0; | ||
|
|
||
| @Override | ||
| public void halt(int status) { | ||
| exitStatus = status; | ||
| haltedLatch.countDown(); | ||
| } | ||
|
|
||
| public boolean waitForRuntimeDeath(long timeout, TimeUnit unit) { | ||
| try { | ||
| return haltedLatch.await(timeout, unit); | ||
| } catch (InterruptedException e) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| private void assertJvmTerminated() { | ||
| assertThat(exitStatus).isEqualTo(WorkerUncaughtExceptionHandler.JVM_TERMINATED_STATUS_CODE); | ||
| } | ||
| } | ||
| } |