Disable profiling in cythonized code by default. (#30938)

* Remove Cython profiling. * Update CHANGES.md
apache · Apr 16, 2024 · 6366bd4 · 6366bd4
1 parent 6bca710
commit 6366bd4
Show file tree

Hide file tree

Showing 12 changed files with 1 addition and 12 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -68,7 +68,7 @@
 
 ## New Features / Improvements
 
-* X feature added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)).
+* Profiling of Cythonized code has been disabled by default. This might improve performance for some Python pipelines ([#30938](https://github.com/apache/beam/pull/30938)).
 * Bigtable enrichment handler now accepts a custom function to build a composite row key. (Python) ([#30974](https://github.com/apache/beam/issues/30975)).
 
 ## Breaking Changes

diff --git a/sdks/python/apache_beam/coders/coder_impl.pxd b/sdks/python/apache_beam/coders/coder_impl.pxd
@@ -15,7 +15,6 @@
 # limitations under the License.
 #
 
-# cython: profile=True
 
 cimport cython
 

diff --git a/sdks/python/apache_beam/metrics/monitoring_infos.py b/sdks/python/apache_beam/metrics/monitoring_infos.py
@@ -16,7 +16,6 @@
 #
 
 # cython: language_level=3
-# cython: profile=True
 
 # pytype: skip-file
 

diff --git a/sdks/python/apache_beam/runners/common.py b/sdks/python/apache_beam/runners/common.py
@@ -14,7 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-# cython: profile=True
 # cython: language_level=3
 
 """Worker operations executor.

diff --git a/sdks/python/apache_beam/runners/worker/opcounters.py b/sdks/python/apache_beam/runners/worker/opcounters.py
@@ -16,7 +16,6 @@
 #
 
 # cython: language_level=3
-# cython: profile=True
 
 """Counters collect the progress of the Worker for reporting to the service."""
 

diff --git a/sdks/python/apache_beam/runners/worker/operations.py b/sdks/python/apache_beam/runners/worker/operations.py
@@ -16,7 +16,6 @@
 #
 
 # cython: language_level=3
-# cython: profile=True
 
 """Worker operations executor."""
 

diff --git a/sdks/python/apache_beam/runners/worker/statesampler_fast.pyx b/sdks/python/apache_beam/runners/worker/statesampler_fast.pyx
@@ -15,7 +15,6 @@
 # limitations under the License.
 #
 
-# cython: profile=True
 # cython: language_level=3
 
 """State sampler for tracking time spent in execution steps.

diff --git a/sdks/python/apache_beam/testing/fast_test_utils.pxd b/sdks/python/apache_beam/testing/fast_test_utils.pxd
@@ -15,7 +15,6 @@
 # limitations under the License.
 #
 
-# cython: profile=True
 
 cimport libc.stdint
 

diff --git a/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pxd b/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pxd
@@ -14,7 +14,6 @@
 # limitations under the License.
 #
 
-# cython: profile=True
 
 """ For internal use only. No backwards compatibility guarantees."""
 

diff --git a/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pyx b/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pyx
@@ -14,7 +14,6 @@
 # limitations under the License.
 #
 
-# cython: profile=True
 # cython: language_level=3
 
 """ For internal use only. No backwards compatibility guarantees."""

diff --git a/sdks/python/apache_beam/utils/counters.pxd b/sdks/python/apache_beam/utils/counters.pxd
@@ -15,7 +15,6 @@
 # limitations under the License.
 #
 
-# cython: profile=True
 # cython: overflowcheck=True
 
 cdef class Counter(object):

diff --git a/sdks/python/apache_beam/utils/windowed_value.py b/sdks/python/apache_beam/utils/windowed_value.py
@@ -22,7 +22,6 @@
 # editing this file as WindowedValues are created for every element for
 # every step in a Beam pipeline.
 
-# cython: profile=True
 # cython: language_level=3
 
 # pytype: skip-file