Merge pull request #27699: Don't make StorageAPI tablerow names case-…

…sensitive
apache · Jul 26, 2023 · 1f4defa · 1f4defa
2 parents d241eae + 2e95849
commit 1f4defa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java b/...platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java
@@ -344,7 +344,7 @@ private SchemaInformation(
             new SchemaInformation(
                 field, Iterables.concat(this.parentSchemas, ImmutableList.of(this)));
         subFields.add(schemaInformation);
-        subFieldsByName.put(field.getName(), schemaInformation);
+        subFieldsByName.put(field.getName().toLowerCase(), schemaInformation);
       }
     }
 
@@ -365,9 +365,9 @@ public TableFieldSchema.Type getType() {
     }
 
     public SchemaInformation getSchemaForField(String name) {
-      SchemaInformation schemaInformation = subFieldsByName.get(name);
+      SchemaInformation schemaInformation = subFieldsByName.get(name.toLowerCase());
       if (schemaInformation == null) {
-        throw new RuntimeException("Schema field not found: " + name);
+        throw new RuntimeException("Schema field not found: " + name.toLowerCase());
       }
       return schemaInformation;
     }

diff --git a/...cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java b/...cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java
@@ -1824,7 +1824,7 @@ public void testCreateNever() throws Exception {
                     new SimpleFunction<Long, TableRow>() {
                       @Override
                       public TableRow apply(Long input) {
-                        return new TableRow().set("name", "name " + input).set("number", input);
+                        return new TableRow().set("NaMe", "name " + input).set("numBEr", input);
                       }
                     }))
             .setCoder(TableRowJsonCoder.of());