Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-43631: [C++] Add C++ implementation of Async C Data Interface #44495

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

GH-43631: [C++] Add C++ implementation of Async C Data Interface #44495

wants to merge 19 commits into from
+554 −1

Commits on Nov 6, 2024

  1. add async implementation

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3a557da View commit details
    Browse the repository at this point in the history

  2. Add C++ bridge impl

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    04bad10 View commit details
    Browse the repository at this point in the history

  3. lint and fix unused

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3a1087b View commit details
    Browse the repository at this point in the history

  4. make explicit

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    fdbf461 View commit details
    Browse the repository at this point in the history

  5. lint

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    81229a3 View commit details
    Browse the repository at this point in the history

  6. use NULLPTR for header

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    756f2d1 View commit details
    Browse the repository at this point in the history

  7. const AllocationType is meaningless

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    062d827 View commit details
    Browse the repository at this point in the history

  8. Update cpp/src/arrow/c/bridge.h 

    Co-authored-by: David Li <[email protected]>
    @zeroshade @lidavidm
    zeroshade and lidavidm committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0c884d7 View commit details
    Browse the repository at this point in the history

  9. Update cpp/src/arrow/c/bridge_test.cc 

    Co-authored-by: David Li <[email protected]>
    @zeroshade @lidavidm
    zeroshade and lidavidm committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    61da90f View commit details
    Browse the repository at this point in the history

  10. suggestions and lint

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7f4f34d View commit details
    Browse the repository at this point in the history

  11. fold error_ and cancelled_ together

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    54db4aa View commit details
    Browse the repository at this point in the history

  12. some simplifying

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    befe131 View commit details
    Browse the repository at this point in the history

  13. more updates from feedback

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    24f5baf View commit details
    Browse the repository at this point in the history

  14. linting

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    708ef89 View commit details
    Browse the repository at this point in the history

  15. add error tests

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6c01d6c View commit details
    Browse the repository at this point in the history

  16. run pre-commit

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f9c5aeb View commit details
    Browse the repository at this point in the history

  17. add WaitForIdle to avoid bad thread shutdown

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    85178f7 View commit details
    Browse the repository at this point in the history

  18. Add device_type to ArrowAsyncProducer

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    04b6092 View commit details
    Browse the repository at this point in the history

  19. update on_schema callback signature

    @zeroshade
    zeroshade committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3c1f0b5 View commit details
    Browse the repository at this point in the history