GH-41815: [Python] add use_threads option to feather.write_feather() #41820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pjh40
force-pushed
the
GH41815_write_feather_use_threads
branch
2 times, most recently
from
a857aae
to
4333111
Compare
pjh40
force-pushed
the
GH41815_write_feather_use_threads
branch
from
4333111
to
ec68ec3
Compare
pjh40
force-pushed
the
GH41815_write_feather_use_threads
branch
from
ec68ec3
to
3669ba2
Compare
pjh40
force-pushed
the
GH41815_write_feather_use_threads
branch
from
3669ba2
to
64fa348
Compare
pjh40
force-pushed
the
GH41815_write_feather_use_threads
branch
from
64fa348
to
3dc0af6
Compare
pjh40
force-pushed
the
GH41815_write_feather_use_threads
branch
from
3dc0af6
to
4f673fd
Compare
Allow the caller to specify serial execution of `write_feather` with the `use_threads=False` option, or allow for a threaded implementation with the default `use_threads=True` option. The serial option is useful in `atexit` contexts, where it is illegal to start a `concurrent.futures.ThreadPoolExecutor`.
Test that `write_feather(..., use_threads=False)` produces the same result as `write_feather(..., use_threads=True)` for a `pandas.DataFrame`.
pjh40
force-pushed
the
GH41815_write_feather_use_threads
branch
from
4f673fd
to
838d59d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
feather.write_feathercould implicitly invokeThreadPoolExecutorwhen writing apandas.DataFrame, making it unusable in anatexitcontext. More details in #41815What changes are included in this PR?
Added a new default
Trueparameteruse_threadstowrite_feather. This name was selected to match that inread_feather. Foruse_threads=True,write_featherpasses annthreads=Noneoption toTable.from_pandas, which will causepandas_compat.dataframe_to_array()to heuristically determine whether to use threads or not. Foruse_threads=False,nthreads=1, which will result in serial behavior.Are these changes tested?
Yes,
test_use_threadsintest_feather.pywas expanded to ensure that serial and parallel writes produce the same file.Are there any user-facing changes?
Yes, new default parameter to user-facing
write_feather.pyarrow.write_feathercan't be used inatexitcontexts to write apandas.DataFrame#41815