Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-41301: [C++] Extract the kernel loops used for PrimitiveTakeExec and generalize to any fixed-width type #41373

Merged
merged 22 commits into from
Jun 10, 2024
Merged

GH-41301: [C++] Extract the kernel loops used for PrimitiveTakeExec and generalize to any fixed-width type #41373

merged 22 commits into from
Jun 10, 2024

Commits on Jun 3, 2024

  1. apacheGH-41188: [C++] Don't recursively produce nulls when appending … 

    …nulls to a FixedSizeListBuilder
    @felipecrv
    felipecrv committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    27d5efb View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. gather_internal.h: Introduce the Gather class helper

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0817d59 View commit details
    Browse the repository at this point in the history

  2. Take: Use Gather for PrimitiveTakeImpl

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    35c409d View commit details
    Browse the repository at this point in the history

  3. Take: Pass bit-width instead of byte-width

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    bc75bfa View commit details
    Browse the repository at this point in the history

  4. Take: Use a Gather specialization for boolean arrays

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9ee75fb View commit details
    Browse the repository at this point in the history

  5. Take: Skip allocating validity bitmap when values and filter don't ha… 

    …ve nulls
    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b0614a0 View commit details
    Browse the repository at this point in the history

  6. Take: Fold the implementation for FSB arrays into the one used for pr… 

    …imitives
    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1fdc401 View commit details
    Browse the repository at this point in the history

  7. Revert "apacheGH-41188: [C++] Don't recursively produce nulls when ap… 

    …pending nulls to a FixedSizeListBuilder"

This reverts commit b31590c.
    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b122382 View commit details
    Browse the repository at this point in the history

  8. gather_internal.h: Please the linter

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    97be842 View commit details
    Browse the repository at this point in the history

  9. gather_internal.h: Small fixup to top-level comment

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d77c758 View commit details
    Browse the repository at this point in the history

  10. gather_internal.h: Rename {->k}WithFactor and use static_assert

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    47ef815 View commit details
    Browse the repository at this point in the history

  11. gather_internal.h: Use int64_t instead of size_t for size factors

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5f635aa View commit details
    Browse the repository at this point in the history

  12. gather_internal.h: Fix assertion: src_validity.offset is not always r… 

    …elated to src_offset_
    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    54ca9a4 View commit details
    Browse the repository at this point in the history

  13. fixup! gather_internal.h: Introduce the Gather class helper

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9f5d834 View commit details
    Browse the repository at this point in the history

  14. fixup! Take: Use a Gather specialization for boolean arrays

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8a089c8 View commit details
    Browse the repository at this point in the history

  15. fixup! gather_internal.h: Rename {->k}WithFactor and use static_assert

    @felipecrv
    felipecrv committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8629277 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. gather_internal.h: Remove inline nspc because force-inline annotation… 

    …s are enough
    @felipecrv
    felipecrv committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    efaeb9c View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Take: Add an ARROW_PREDICT_TRUE that reduces binary size 

      Impact on origin/main:

    Before this commit
     -0.1%    -504  +0.5% +1.45Ki    TOTAL

    After this commit
     -0.1%    -392  +0.5% +1.27Ki    TOTAL
    @felipecrv
    felipecrv committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8f884c6 View commit details
    Browse the repository at this point in the history

  2. macros.h: Add ARROW_COMPILER_UNREACHABLE macro

    @felipecrv
    felipecrv committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a64a582 View commit details
    Browse the repository at this point in the history

  3. Take: Move a few branches around and reduce binary code size further 

    In a follow-up PR I'm adding Status return type out of necessity, so
this change is not only for binary size reasons.

    -0.1%    -528  +0.5% +1.21Ki    TOTAL
    @felipecrv
    felipecrv committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c31e5be View commit details
    Browse the repository at this point in the history

  4. Take: Add note about typename tparams in FixedWidthTakeImpl

    @felipecrv
    felipecrv committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    075508c View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Remove ARROW_COMPILER_UNREACHABLE and use default+DCHECK on the switch

    @felipecrv
    felipecrv committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ca6937c View commit details
    Browse the repository at this point in the history