Revert the changes in FixedSizeListBuilder and disable some test cases

apache · Apr 20, 2024 · c29cc3e · c29cc3e
1 parent c51e25d
commit c29cc3e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/cpp/src/arrow/array/builder_nested.cc b/cpp/src/arrow/array/builder_nested.cc
@@ -213,13 +213,13 @@ Status FixedSizeListBuilder::AppendValues(int64_t length, const uint8_t* valid_b
 Status FixedSizeListBuilder::AppendNull() {
   RETURN_NOT_OK(Reserve(1));
   UnsafeAppendToBitmap(false);
-  return value_builder_->AppendEmptyValues(list_size_);
+  return value_builder_->AppendNulls(list_size_);
 }
 
 Status FixedSizeListBuilder::AppendNulls(int64_t length) {
   RETURN_NOT_OK(Reserve(length));
   UnsafeAppendToBitmap(length, false);
-  return value_builder_->AppendEmptyValues(list_size_ * length);
+  return value_builder_->AppendNulls(list_size_ * length);
 }
 
 Status FixedSizeListBuilder::ValidateOverflow(int64_t new_elements) {

diff --git a/cpp/src/arrow/util/fixed_width_test.cc b/cpp/src/arrow/util/fixed_width_test.cc
@@ -100,7 +100,10 @@ TEST_F(TestFixedWidth, IsFixedWidthModuloNesting) {
 
   arr = ArraySpan{*fsl_int_nulls_array_->data()};
   // Nulls at the top-level of the array are allowed by IsFixedWidthModuloNesting.
-  ASSERT_TRUE(IsFixedWidthModuloNesting(arr, /*force_null_count=*/false));
+  //
+  // TODO(GH-10157): ArrayFromJSON uses FixedSizeListBuilder which currently
+  // produces nulls on the child data if one of the list-typed elements is null.
+  // ASSERT_TRUE(IsFixedWidthModuloNesting(arr, /*force_null_count=*/false));
 
   arr = ArraySpan{*fsl_int_inner_nulls_array_->data()};
   // Inner nulls are not allowed by IsFixedWidthModuloNesting.