GH-32206: Aligning R's GcsFileSystem::Make call with new definition.

apache · Oct 25, 2024 · 415e517 · 415e517
1 parent 3d2ad22
commit 415e517
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/cpp/src/arrow/filesystem/gcsfs.h b/cpp/src/arrow/filesystem/gcsfs.h
@@ -230,10 +230,6 @@ class ARROW_EXPORT GcsFileSystem : public FileSystem {
       const std::string& path,
       const std::shared_ptr<const KeyValueMetadata>& metadata) override;
 
-  ARROW_DEPRECATED("Deprecated in 19.0.0. Use the Result version instead.")
-  static std::shared_ptr<GcsFileSystem> Make(
-      const GcsOptions& options, const io::IOContext& = io::default_io_context());
-
   /// Create a GcsFileSystem instance from the given options.
   static Result<std::shared_ptr<GcsFileSystem>> Make(
       const GcsOptions& options, const io::IOContext& = io::default_io_context());

diff --git a/r/src/filesystem.cpp b/r/src/filesystem.cpp
@@ -359,8 +359,8 @@ void FinalizeS3() {
 std::shared_ptr<arrow::KeyValueMetadata> strings_to_kvm(cpp11::strings metadata);
 
 // [[gcs::export]]
-std::shared_ptr<fs::GcsFileSystem> fs___GcsFileSystem__Make(bool anonymous,
-                                                            cpp11::list options) {
+Result<std::shared_ptr<GcsFileSystem>> fs___GcsFileSystem__Make(bool anonymous,
+                                                                cpp11::list options) {
   fs::GcsOptions gcs_opts;
 
   // Handle auth (anonymous, credentials, default)
@@ -429,7 +429,7 @@ std::shared_ptr<fs::GcsFileSystem> fs___GcsFileSystem__Make(bool anonymous,
   }
 
   auto io_context = MainRThread::GetInstance().CancellableIOContext();
-  // TODO(ARROW-16884): update when this returns Result
+
   return fs::GcsFileSystem::Make(gcs_opts, io_context);
 }