Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dockerfile build failed #2918

Merged
merged 3 commits into from
Feb 1, 2024
Merged

fix: dockerfile build failed #2918

merged 3 commits into from
Feb 1, 2024

Conversation

zll600
Copy link
Contributor

@zll600 zll600 commented Jan 30, 2024

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

  • use registry.yarnpkg.com instead of registry.taobao.com
  • update Dockerfile use copy of local file instead of use git clone
  • update ci file to remove APISIX_DASHBOARD_VERSION=master

Related issues

fix/resolve #2917

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8bc9b9) 70.55% compared to head (cc1d9c1) 77.46%.
Report is 1 commits behind head on master.

❗ Current head cc1d9c1 differs from pull request most recent head 625b245. Consider uploading reports for the commit 625b245 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2918      +/-   ##
==========================================
+ Coverage   70.55%   77.46%   +6.91%     
==========================================
  Files         201      139      -62     
  Lines        7846     3746    -4100     
  Branches      881      881              
==========================================
- Hits         5536     2902    -2634     
+ Misses       2001      844    -1157     
+ Partials      309        0     -309     
Flag Coverage Δ
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 77.46% <ø> (+8.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zll600
Copy link
Contributor Author

zll600 commented Jan 31, 2024

@monkeyDluffy6017 @nic-chen @bzp2010 Could you help review when you have time?

@zll600 zll600 changed the title fix: remove taobao mirror fix: dockerfile build failed Jan 31, 2024
Dockerfile Show resolved Hide resolved
@zll600 zll600 requested a review from starsz February 1, 2024 01:46
@monkeyDluffy6017 monkeyDluffy6017 merged commit ad697c6 into apache:master Feb 1, 2024
19 checks passed
@zll600
Copy link
Contributor Author

zll600 commented Feb 18, 2024

@monkeyDluffy6017 Should we backport this to release/3.0?

@monkeyDluffy6017
Copy link

No plan for now @zll600

@zll600
Copy link
Contributor Author

zll600 commented Feb 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile build failed
5 participants