Safe migration

anyone-oslo · Feb 2, 2024 · e42af67 · e42af67
1 parent 2c94c64
commit e42af67
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -95,3 +95,7 @@ Rails/HelperInstanceVariable:
 Rails/OutputSafety:
   Exclude:
     - "app/formatters/pages_core/html_formatter.rb"
+
+Rails/SkipsModelValidations:
+  Exclude:
+    - "db/migrate/**/*"
diff --git a/db/migrate/20240126160700_add_2fa_fields.rb b/db/migrate/20240126160700_add_2fa_fields.rb
@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 class Add2faFields < ActiveRecord::Migration[7.0]
+  class User < ApplicationRecord; end
+
   def change
     change_table :users do |t|
       t.boolean :otp_enabled, null: false, default: false
@@ -14,7 +16,9 @@ def change
 
     reversible do |dir|
       dir.up do
-        User.find_each { |u| u.update(session_token: SecureRandom.hex(32)) }
+        User.find_each do |u|
+          u.update_columns(session_token: SecureRandom.hex(32))
+        end
         change_column_null :users, :session_token, false
       end
     end